From: Jani Nikula <jani.nikula@linux.intel.com>
To: Shen Lichuan <shenlichuan@vivo.com>,
rodrigo.vivi@intel.com, joonas.lahtinen@linux.intel.com,
tursulin@ursulin.net, airlied@gmail.com, simona@ffwll.ch
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
opensource.kernel@vivo.com, Shen Lichuan <shenlichuan@vivo.com>
Subject: Re: [PATCH v1] drm/i915/hdmi: Convert comma to semicolon
Date: Wed, 18 Sep 2024 12:32:50 +0300 [thread overview]
Message-ID: <87msk5b931.fsf@intel.com> (raw)
In-Reply-To: <20240918032804.9269-1-shenlichuan@vivo.com>
On Wed, 18 Sep 2024, Shen Lichuan <shenlichuan@vivo.com> wrote:
> To ensure code clarity and prevent potential errors, it's advisable
> to employ the ';' as a statement separator, except when ',' are
> intentionally used for specific purposes.
>
> Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>
Already fixed by commit 7cd1049a33ca ("drm/i915/hdmi: convert comma to
semicolon").
Please use the latest drm-tip branch of [1] when contributing to i915 or
xe drivers.
BR,
Jani.
[1] https://gitlab.freedesktop.org/drm/tip
> ---
> drivers/gpu/drm/i915/display/intel_hdmi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index cd9ee171e0df..f2dce9896a48 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -1310,8 +1310,8 @@ static int intel_hdmi_hdcp_write(struct intel_digital_port *dig_port,
> memcpy(&write_buf[1], buffer, size);
>
> msg.addr = DRM_HDCP_DDC_ADDR;
> - msg.flags = 0,
> - msg.len = size + 1,
> + msg.flags = 0;
> + msg.len = size + 1;
> msg.buf = write_buf;
>
> ret = i2c_transfer(ddc, &msg, 1);
--
Jani Nikula, Intel
prev parent reply other threads:[~2024-09-18 9:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 3:28 [PATCH v1] drm/i915/hdmi: Convert comma to semicolon Shen Lichuan
2024-09-18 9:32 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msk5b931.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=rodrigo.vivi@intel.com \
--cc=shenlichuan@vivo.com \
--cc=simona@ffwll.ch \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox