* [PATCH v1] drm/i915/hdmi: Convert comma to semicolon
@ 2024-09-18 3:28 Shen Lichuan
2024-09-18 9:32 ` Jani Nikula
0 siblings, 1 reply; 2+ messages in thread
From: Shen Lichuan @ 2024-09-18 3:28 UTC (permalink / raw)
To: jani.nikula, rodrigo.vivi, joonas.lahtinen, tursulin, airlied,
simona
Cc: intel-gfx, intel-xe, dri-devel, linux-kernel, opensource.kernel,
Shen Lichuan
To ensure code clarity and prevent potential errors, it's advisable
to employ the ';' as a statement separator, except when ',' are
intentionally used for specific purposes.
Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>
---
drivers/gpu/drm/i915/display/intel_hdmi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
index cd9ee171e0df..f2dce9896a48 100644
--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
@@ -1310,8 +1310,8 @@ static int intel_hdmi_hdcp_write(struct intel_digital_port *dig_port,
memcpy(&write_buf[1], buffer, size);
msg.addr = DRM_HDCP_DDC_ADDR;
- msg.flags = 0,
- msg.len = size + 1,
+ msg.flags = 0;
+ msg.len = size + 1;
msg.buf = write_buf;
ret = i2c_transfer(ddc, &msg, 1);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] drm/i915/hdmi: Convert comma to semicolon
2024-09-18 3:28 [PATCH v1] drm/i915/hdmi: Convert comma to semicolon Shen Lichuan
@ 2024-09-18 9:32 ` Jani Nikula
0 siblings, 0 replies; 2+ messages in thread
From: Jani Nikula @ 2024-09-18 9:32 UTC (permalink / raw)
To: Shen Lichuan, rodrigo.vivi, joonas.lahtinen, tursulin, airlied,
simona
Cc: intel-gfx, intel-xe, dri-devel, linux-kernel, opensource.kernel,
Shen Lichuan
On Wed, 18 Sep 2024, Shen Lichuan <shenlichuan@vivo.com> wrote:
> To ensure code clarity and prevent potential errors, it's advisable
> to employ the ';' as a statement separator, except when ',' are
> intentionally used for specific purposes.
>
> Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>
Already fixed by commit 7cd1049a33ca ("drm/i915/hdmi: convert comma to
semicolon").
Please use the latest drm-tip branch of [1] when contributing to i915 or
xe drivers.
BR,
Jani.
[1] https://gitlab.freedesktop.org/drm/tip
> ---
> drivers/gpu/drm/i915/display/intel_hdmi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index cd9ee171e0df..f2dce9896a48 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -1310,8 +1310,8 @@ static int intel_hdmi_hdcp_write(struct intel_digital_port *dig_port,
> memcpy(&write_buf[1], buffer, size);
>
> msg.addr = DRM_HDCP_DDC_ADDR;
> - msg.flags = 0,
> - msg.len = size + 1,
> + msg.flags = 0;
> + msg.len = size + 1;
> msg.buf = write_buf;
>
> ret = i2c_transfer(ddc, &msg, 1);
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-18 9:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-18 3:28 [PATCH v1] drm/i915/hdmi: Convert comma to semicolon Shen Lichuan
2024-09-18 9:32 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox