public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Herve Codina <herve.codina@bootlin.com>,
	Matti Vaittinen <mazziesaccount@gmail.com>,
	Herve Codina <herve.codina@bootlin.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Richard Weinberger <richard@nod.at>,
	Anton Ivanov <anton.ivanov@cambridgegreys.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	Marc Zyngier <maz@kernel.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-um@lists.infradead.org,
	Allan Nielsen <allan.nielsen@microchip.com>,
	Horatiu Vultur <horatiu.vultur@microchip.com>,
	Steen Hegelund <steen.hegelund@microchip.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 00/23] Introduce irq_domain_instanciate()
Date: Mon, 17 Jun 2024 15:57:44 +0200	[thread overview]
Message-ID: <87msnju0x3.ffs@tglx> (raw)
In-Reply-To: <20240614173232.1184015-1-herve.codina@bootlin.com>

Herve!

On Fri, Jun 14 2024 at 19:32, Herve Codina wrote:
> During the review, it was asked to rework the irq domain modification in
> order to avoid more wrappers and a new irq_domain_instanciate() function
> was proposed [2].
>
> Also a patch [3] sent by Maitti Vaittinen can benefit of this new
> irq_domain_instanciate() function. Even if Maitti's use case is not
> handle yet in this series, it should not be a big deal add support for
> it on top of this current series.
>
> So, this current series introduces this new irq_domain_instanciate()
> function and migrate existing wrappers and functions to this new
> function (patches 1 to 20).
>
> It then introduces the first driver that uses directly this new function
> with the init()/exit() hooks set: the Microchip LAN966x OIC driver
> (patches 21 to 23).
>
> Existing irqchip drivers are not converted yet to use this new API
> function in the same way as the LAN966x OIC driver does.
> I prefer to have this series accepted first to avoid doing and re-doing
> several times the same modifications on existing drivers depending on
> changes requested on this current series review.

I'm truly impressed by the quality of this patch set.

The only nitpicks I found was the formatting of the struct
initializers. I fixed them up for you this time. Keep up the good work!

The result can be found at:

   git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq/core

Matti, can you please build your extensions on top of that?

Thanks,

        tglx


  parent reply	other threads:[~2024-06-17 13:57 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-14 17:32 [PATCH 00/23] Introduce irq_domain_instanciate() Herve Codina
2024-06-14 17:32 ` [PATCH 01/23] irqdomain: Introduce irq_domain_free() Herve Codina
2024-06-17 13:51   ` [tip: irq/core] " tip-bot2 for Herve Codina
2024-06-14 17:32 ` [PATCH 02/23] irqdomain: Introduce irq_domain_instantiate() Herve Codina
2024-06-17 13:51   ` [tip: irq/core] " tip-bot2 for Herve Codina
2024-06-14 17:32 ` [PATCH 03/23] irqdomain: Fixed unbalanced fwnode get and put Herve Codina
2024-06-17 13:51   ` [tip: irq/core] " tip-bot2 for Herve Codina
2024-06-14 17:32 ` [PATCH 04/23] irqdomain: Constify parameter in is_fwnode_irqchip() Herve Codina
2024-06-17 13:51   ` [tip: irq/core] " tip-bot2 for Herve Codina
2024-06-14 17:32 ` [PATCH 05/23] irqdomain: Use a dedicated function to set the domain name Herve Codina
2024-06-17 13:51   ` [tip: irq/core] " tip-bot2 for Herve Codina
2024-06-14 17:32 ` [PATCH 06/23] irqdomain: Convert __irq_domain_create() to use struct irq_domain_info Herve Codina
2024-06-17 13:51   ` [tip: irq/core] " tip-bot2 for Herve Codina
2024-06-14 17:32 ` [PATCH 07/23] irqdomain: Handle additional domain flags in irq_domain_instantiate() Herve Codina
2024-06-17 13:51   ` [tip: irq/core] " tip-bot2 for Herve Codina
2024-06-14 17:32 ` [PATCH 08/23] irqdomain: Handle domain hierarchy parent " Herve Codina
2024-06-17 13:51   ` [tip: irq/core] " tip-bot2 for Herve Codina
2024-06-14 17:32 ` [PATCH 09/23] irqdomain: Use irq_domain_instantiate() for hierarchy domain creation Herve Codina
2024-06-17 13:51   ` [tip: irq/core] " tip-bot2 for Herve Codina
2024-06-14 17:32 ` [PATCH 10/23] irqdomain: Make __irq_domain_create() return an error code Herve Codina
2024-06-17 13:51   ` [tip: irq/core] " tip-bot2 for Herve Codina
2024-06-14 17:32 ` [PATCH 11/23] irqdomain: Handle domain bus token in irq_domain_create() Herve Codina
2024-06-17 13:51   ` [tip: irq/core] " tip-bot2 for Herve Codina
2024-06-14 17:32 ` [PATCH 12/23] irqdomain: Introduce init() and exit() hooks Herve Codina
2024-06-17 13:51   ` [tip: irq/core] " tip-bot2 for Herve Codina
2024-06-14 17:32 ` [PATCH 13/23] genirq/generic_chip: Introduce irq_domain_{alloc,remove}_generic_chips() Herve Codina
2024-06-17 13:51   ` [tip: irq/core] " tip-bot2 for Herve Codina
2024-06-14 17:32 ` [PATCH 14/23] genirq/generic_chip: Introduce init() and exit() hooks Herve Codina
2024-06-17 13:51   ` [tip: irq/core] " tip-bot2 for Herve Codina
2024-06-14 17:32 ` [PATCH 15/23] irqdomain: Add support for generic irq chips creation before publishing a domain Herve Codina
2024-06-17 13:51   ` [tip: irq/core] " tip-bot2 for Herve Codina
2024-06-14 17:32 ` [PATCH 16/23] irqdomain: Add a resource managed version of irq_domain_instantiate() Herve Codina
2024-06-17 13:51   ` [tip: irq/core] " tip-bot2 for Herve Codina
2024-06-14 17:32 ` [PATCH 17/23] irqdomain: Convert __irq_domain_add() wrappers to irq_domain_instantiate() Herve Codina
2024-06-17 13:51   ` [tip: irq/core] " tip-bot2 for Herve Codina
2024-06-14 17:32 ` [PATCH 18/23] irqdomain: Convert domain creation functions " Herve Codina
2024-06-17 13:51   ` [tip: irq/core] " tip-bot2 for Herve Codina
2024-06-14 17:32 ` [PATCH 19/23] um: virt-pci: Use irq_domain_instantiate() Herve Codina
2024-06-17 13:51   ` [tip: irq/core] _PATCH_19_23_um_virt_pci_Use_irq_domain_instantiate_ tip-bot2 for Herve Codina
2024-06-14 17:32 ` [PATCH 20/23] irqdomain: Remove __irq_domain_add() Herve Codina
2024-06-17 13:51   ` [tip: irq/core] " tip-bot2 for Herve Codina
2024-06-14 17:32 ` [PATCH 21/23] dt-bindings: interrupt-controller: Add support for Microchip LAN966x OIC Herve Codina
2024-06-17 13:51   ` [tip: irq/core] " tip-bot2 for Herve Codina
2024-06-14 17:32 ` [PATCH 22/23] irqchip: Add support for " Herve Codina
2024-06-17 13:51   ` [tip: irq/core] " tip-bot2 for Herve Codina
2024-06-14 17:32 ` [PATCH 23/23] MAINTAINERS: Add the Microchip LAN966x OIC driver entry Herve Codina
2024-06-17 13:51   ` [tip: irq/core] " tip-bot2 for Herve Codina
2024-06-17 13:57 ` Thomas Gleixner [this message]
2024-06-18 13:05   ` [PATCH 00/23] Introduce irq_domain_instanciate() Matti Vaittinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87msnju0x3.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=allan.nielsen@microchip.com \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=herve.codina@bootlin.com \
    --cc=horatiu.vultur@microchip.com \
    --cc=johannes@sipsolutions.net \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=maz@kernel.org \
    --cc=mazziesaccount@gmail.com \
    --cc=richard@nod.at \
    --cc=robh@kernel.org \
    --cc=steen.hegelund@microchip.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox