Re: [PATCH 13/17] Add conf.h

Kalle Valo
2024-05-23T07:08:54Z

Krzysztof Kozlowski <krzk@kernel.org> writes:

> On 21/05/2024 19:18, michael.nemanov@ti.com wrote:
>> From: Michael Nemanov <Michael.Nemanov@ti.com>
>>
>> Various HW / FW / Driver controls unique for the CC33xx that
>> can be set by OEMs.
>>
>> Signed-off-by: Michael Nemanov <michael.nemanov@ti.com>
>> ---
>> drivers/net/wireless/ti/cc33xx/conf.h | 1246 +++++++++++++++++++++++++
>
> So you are adding one file by another? This does not help review.
>
> Add logical chunks, e.g. users of header after the header. Or all
> headers together. Or some features incrementally, like basic working
> driver and then feature foo and bar.

For new wireless drivers my recommendation has been to submit for review
one file per patch but the final driver to be commited would be just one
patch:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#new_driver

--