From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37550C4167B for ; Sun, 26 Nov 2023 10:49:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229747AbjKZKtF (ORCPT ); Sun, 26 Nov 2023 05:49:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjKZKtE (ORCPT ); Sun, 26 Nov 2023 05:49:04 -0500 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98590C8 for ; Sun, 26 Nov 2023 02:49:10 -0800 (PST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1346B5C0164; Sun, 26 Nov 2023 05:49:10 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 26 Nov 2023 05:49:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1700995750; x=1701082150; bh=EO MOkS2/UVozc3tALLYGluUBGVVrqVPD4CI9ogonssc=; b=TXqxbh4W5kN02u7RE4 UXupyiBMPkXWdtRWLtdaLcaFnh5wJr+nzZGSM5TtGtqFbGXLhqTwD6R6Sqq6txiI qwzDhywVPLwVi7lpuDYe4izVAhTlL4Rfluk1EmWcHENP1PuNTmBViBiLtg9C2jGv YNSmKhtjiOh8KZO4DdUbbee9CDrYTdhbdZp9qvC6QMfMwzLEan4lqQlen48bdaNI 9HZrAbF+RlthQSnsG1u2471ijoL6lZRgLJH2TalN99qZzmA3jPy5Uz2RXS0aCxQZ s873XZsmE3/rW8y+71YsS2FfLl68ivcvS1ry4BPBI9BUOFto2CnC0BY4SkgfOrv8 nb/g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1700995750; x=1701082150; bh=EOMOkS2/UVozc 3tALLYGluUBGVVrqVPD4CI9ogonssc=; b=e51fYF0tzQyTc6HkhXSV86wg1f6XL mcfG5thwKnwmZpODNM5iGCpjfNfPr6tNBBL0io7TRNma83nisyWOohPgTE/PFRbR 265Vr9vci4+/aIuU+laad+IQ5alB55qMIt6K+U+S1gl1xVXJAX07Iv/WqoxJiH6E 0oRWhDgvgRBfQ5+MCXeW0JOM4VEpDvgXPrWRs3JG70bCUvkkR/hg7WR1FQutNV3U w0pgpMpPVE05+YJA7mmN0hMYW+DGmXKlKKObqMn1qzHAY0jopSwNpTXjfq2yjFNf SgR8PLEuYAJe8PPuOwJTF+99svu7qJwJ1sOJL/crs84UxiWu342KP9mKw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudehledgvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvvefuffgjkfggtgesthdtredttdertdenucfhrhhomhepifgrrhih ucftohhokhgrrhguuceoghgrrhihrhhoohhkrghrugesfhgrshhtmhgrihhlrdhorhhgqe enucggtffrrghtthgvrhhnpeefleffhfegtefffefgfedugeehhfdvueefffegkeejvdeg leeiueelkeeiuddvheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehgrghrhihrohhokhgrrhgusehfrghsthhmrghilhdrohhrgh X-ME-Proxy: Feedback-ID: ifd194980:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 26 Nov 2023 05:49:09 -0500 (EST) References: <20231125223432.13780-1-garyrookard@fastmail.org> <20231125223432.13780-5-garyrookard@fastmail.org> <2023112622-jigsaw-scrambler-d385@gregkh> User-agent: mu4e 1.10.6; emacs 29.1 From: Gary Rookard To: Greg KH Cc: philipp.g.hortmann@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] staging: rtl8192e: renamed variable nDataRate Date: Sun, 26 Nov 2023 05:48:08 -0500 In-reply-to: <2023112622-jigsaw-scrambler-d385@gregkh> Message-ID: <87msv0x00h.fsf@fastmail.org> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg KH writes: > On Sat, Nov 25, 2023 at 05:34:31PM -0500, Gary Rookard wrote: >> -u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate) >> +u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 n_data_rate) > > Why are you keeping the "n"? It's not needed, right? Remember, these > were written in "Hungarian notation" which uses the variable name to > denote the type of the variable, so "n" means "number" perhaps? So it > can be dropped. > > thanks, > > greg k-h Okay, will redo. Regards, Gary