* [PATCH] ALSA: hda/realtek: Enable Mute LED on HP 255 G10
@ 2023-11-12 16:18 Matus Malych
2023-11-13 9:48 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Matus Malych @ 2023-11-12 16:18 UTC (permalink / raw)
To: tiwai; +Cc: alsa-devel, linux-kernel, Matus Malych
HP 255 G10 has a mute LED that can be made to work using quirk
ALC236_FIXUP_HP_MUTE_LED_COEFBIT2. Enable already existing quirk.
Signed-off-by: Matus Malych <matus@malych.org>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index cdd808e02b44..bda4e9cb8f98 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9833,6 +9833,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x88d0, "HP Pavilion 15-eh1xxx (mainboard 88D0)", ALC287_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8902, "HP OMEN 16", ALC285_FIXUP_HP_MUTE_LED),
SND_PCI_QUIRK(0x103c, 0x890e, "HP 255 G8 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
+ SND_PCI_QUIRK(0x103c, 0x8b2f, "HP 255 15.6 inch G10 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
SND_PCI_QUIRK(0x103c, 0x8919, "HP Pavilion Aero Laptop 13-be0xxx", ALC287_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x896d, "HP ZBook Firefly 16 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x896e, "HP EliteBook x360 830 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ALSA: hda/realtek: Enable Mute LED on HP 255 G10
2023-11-12 16:18 [PATCH] ALSA: hda/realtek: Enable Mute LED on HP 255 G10 Matus Malych
@ 2023-11-13 9:48 ` Takashi Iwai
2023-11-14 13:35 ` [PATCH v2] " Matus Malych
0 siblings, 1 reply; 4+ messages in thread
From: Takashi Iwai @ 2023-11-13 9:48 UTC (permalink / raw)
To: Matus Malych; +Cc: tiwai, alsa-devel, linux-kernel
On Sun, 12 Nov 2023 17:18:22 +0100,
Matus Malych wrote:
>
> HP 255 G10 has a mute LED that can be made to work using quirk
> ALC236_FIXUP_HP_MUTE_LED_COEFBIT2. Enable already existing quirk.
>
> Signed-off-by: Matus Malych <matus@malych.org>
Thanks for the patch.
The quirk entries are sorted in PCI SSID order.
Could you correct the position to put and resubmit?
thanks,
Takashi
> ---
> sound/pci/hda/patch_realtek.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index cdd808e02b44..bda4e9cb8f98 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9833,6 +9833,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x103c, 0x88d0, "HP Pavilion 15-eh1xxx (mainboard 88D0)", ALC287_FIXUP_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8902, "HP OMEN 16", ALC285_FIXUP_HP_MUTE_LED),
> SND_PCI_QUIRK(0x103c, 0x890e, "HP 255 G8 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
> + SND_PCI_QUIRK(0x103c, 0x8b2f, "HP 255 15.6 inch G10 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
> SND_PCI_QUIRK(0x103c, 0x8919, "HP Pavilion Aero Laptop 13-be0xxx", ALC287_FIXUP_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x896d, "HP ZBook Firefly 16 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x896e, "HP EliteBook x360 830 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] ALSA: hda/realtek: Enable Mute LED on HP 255 G10
2023-11-13 9:48 ` Takashi Iwai
@ 2023-11-14 13:35 ` Matus Malych
2023-11-14 16:49 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Matus Malych @ 2023-11-14 13:35 UTC (permalink / raw)
To: tiwai; +Cc: alsa-devel, linux-kernel, Matus Malych
HP 255 G10 has a mute LED that can be made to work using quirk
ALC236_FIXUP_HP_MUTE_LED_COEFBIT2.
Enable already existing quirk - at correct line to keep order
Signed-off-by: Matus Malych <matus@malych.org>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index cdd808e02b44..3c85b8247c11 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9868,6 +9868,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8abb, "HP ZBook Firefly 14 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8ad1, "HP EliteBook 840 14 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8b2f, "HP 255 15.6 inch G10 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
SND_PCI_QUIRK(0x103c, 0x8b42, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8b43, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8b44, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] ALSA: hda/realtek: Enable Mute LED on HP 255 G10
2023-11-14 13:35 ` [PATCH v2] " Matus Malych
@ 2023-11-14 16:49 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2023-11-14 16:49 UTC (permalink / raw)
To: Matus Malych; +Cc: tiwai, alsa-devel, linux-kernel
On Tue, 14 Nov 2023 14:35:25 +0100,
Matus Malych wrote:
>
> HP 255 G10 has a mute LED that can be made to work using quirk
> ALC236_FIXUP_HP_MUTE_LED_COEFBIT2.
> Enable already existing quirk - at correct line to keep order
>
> Signed-off-by: Matus Malych <matus@malych.org>
Thanks, applied now.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-14 16:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-12 16:18 [PATCH] ALSA: hda/realtek: Enable Mute LED on HP 255 G10 Matus Malych
2023-11-13 9:48 ` Takashi Iwai
2023-11-14 13:35 ` [PATCH v2] " Matus Malych
2023-11-14 16:49 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox