From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 535C2CDB47E for ; Wed, 18 Oct 2023 13:20:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231530AbjJRNUQ (ORCPT ); Wed, 18 Oct 2023 09:20:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231159AbjJRNUO (ORCPT ); Wed, 18 Oct 2023 09:20:14 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3925383 for ; Wed, 18 Oct 2023 06:20:13 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1697635211; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/MVR+ADnAzu3IGVyOn/9fY32v046O2wGqRN2Zyaap7Q=; b=pBwrt03+GeAi+FQfUhEzYlJyTDBHynbcTfzFBneHaNp5cVzoz6o9GDl0n7jEtP4W1be1o5 e9YgTSvMzOt8OPfU24bDmac44M+y9Af2WSI9cl+xld0M8U96INTYo/+masnfS5bqh3SkRG u+ksy29pw6eGpL4vckmofqZfX2BYBUqDtPNh3/DAA5kAESEy6xrSh/JGPJ5ocx6jryQoou vdc6WPZFdlKSxZWxFPDvwZ9BgfSqAo7uDIUFLCVHEuJnv7GJGmn53gqs4qKxs5L1jwWkBJ OMZJ0rPzzDfNMfOUhuK8ufaGunymoWc866q7nxUlvHgccQPWYVuyCpBl7insgg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1697635211; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/MVR+ADnAzu3IGVyOn/9fY32v046O2wGqRN2Zyaap7Q=; b=J3c0F6Hq6HOJlQxcnCHwK1Kplqf9c2eGYCph997j1TjdQeVGV5uTEVmLVaHEb6ketau6do VeoOhUJ3DWb/ZTDg== To: Borislav Petkov Cc: LKML , x86@kernel.org Subject: Re: [patch V5 03/39] x86/boot/32: De-uglify the 2/3 level paging difference in mk_early_pgtbl_32() In-Reply-To: <20231018100023.GAZS+st5ePdAQjnO4z@fat_crate.local> References: <20231017200758.877560658@linutronix.de> <20231017211722.111059491@linutronix.de> <20231018100023.GAZS+st5ePdAQjnO4z@fat_crate.local> Date: Wed, 18 Oct 2023 15:20:10 +0200 Message-ID: <87mswg3w51.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 18 2023 at 12:00, Borislav Petkov wrote: > On Tue, Oct 17, 2023 at 11:23:26PM +0200, Thomas Gleixner wrote: >> Move the ifdeffery out of the function and use proper typedefs to make it >> work for both 2 and 3 level paging. >> >> No functional change. >> >> Signed-off-by: Thomas Gleixner >> --- >> V5: New patch >> --- >> arch/x86/kernel/head32.c | 38 +++++++++++++++++++++----------------- >> 1 file changed, 21 insertions(+), 17 deletions(-) >> >> --- a/arch/x86/kernel/head32.c >> +++ b/arch/x86/kernel/head32.c >> @@ -71,39 +71,43 @@ asmlinkage __visible void __init __noret >> */ >> void __init mk_early_pgtbl_32(void); > > Lemme zap that forward declaration too - it looks redundant. Up to the point where the compiler complains about a missing prototype for a global visible function, which will bring it back faster than you think. :)