From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 548BEE92FF8 for ; Fri, 6 Oct 2023 09:06:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231312AbjJFJGY (ORCPT ); Fri, 6 Oct 2023 05:06:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231215AbjJFJGV (ORCPT ); Fri, 6 Oct 2023 05:06:21 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A094FAC for ; Fri, 6 Oct 2023 02:06:19 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5F42D2184F; Fri, 6 Oct 2023 09:06:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1696583178; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WpnHH57W2rqGvjWQNsMwZCbEstkqESxFibpY09kHSig=; b=fHAUunXWyVaIeY20CuyxusDqAlgcOQUS5pngiLHz2p6Kvffm5JrVRiss+XIYDm0keZ4eSz 5wGdCMQxOhCU2bhNQu/XOcy60dqDxOYA1hTnegKTcYfPgykNa6cH++HMbJ24l9d+NLfISh DNSiPJL/pDA9HQlwd1rfKZlqGDe63SY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1696583178; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WpnHH57W2rqGvjWQNsMwZCbEstkqESxFibpY09kHSig=; b=En1gdIt9xO52znWYshL/J8MO59g1hrsnGrdGYBpmh5uUg8o1N4GLfUEcK+Mb0BbzcazTYh 5yU+2i3ix38DCMDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1F76513A2E; Fri, 6 Oct 2023 09:06:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id +j68BgrOH2WkKwAAMHmgww (envelope-from ); Fri, 06 Oct 2023 09:06:18 +0000 Date: Fri, 06 Oct 2023 11:06:17 +0200 Message-ID: <87mswww25y.wl-tiwai@suse.de> From: Takashi Iwai To: Stefan Binding Cc: Jaroslav Kysela , Takashi Iwai , , , , kernel test robot , "Dan Carpenter" Subject: Re: [PATCH v1] ALSA: hda: cs35l41: Cleanup and fix double free in firmware request In-Reply-To: <20231003142138.180108-1-sbinding@opensource.cirrus.com> References: <20231003142138.180108-1-sbinding@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 03 Oct 2023 16:21:38 +0200, Stefan Binding wrote: > > There is an unlikely but possible double free when loading firmware, > and a missing free calls if a firmware is successfully requested but > the coefficient file request fails, leading to the fallback firmware > request occurring without clearing the previously loaded firmware. > > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/r/202309291331.0JUUQnPT-lkp@intel.com/ > > Signed-off-by: Stefan Binding Applied now (with additional Fixes tag). At the next time, please try to put the Fixes tag for a fix like this. thanks, Takashi