From: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
To: Kemeng Shi <shikemeng@huaweicloud.com>,
tytso@mit.edu, adilger.kernel@dilger.ca
Cc: ojaswin@linux.ibm.com, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 01/12] ext4: make state in ext4_mb_mark_bb to be bool
Date: Thu, 28 Sep 2023 14:01:34 +0530 [thread overview]
Message-ID: <87msx6r95l.fsf@doe.com> (raw)
In-Reply-To: <20230928160407.142069-2-shikemeng@huaweicloud.com>
Kemeng Shi <shikemeng@huaweicloud.com> writes:
> As state could only be either 0 or 1, just make it bool.
>
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
> ---
> fs/ext4/ext4.h | 2 +-
> fs/ext4/extents.c | 4 ++--
> fs/ext4/fast_commit.c | 8 ++++----
> fs/ext4/mballoc.c | 4 ++--
> 4 files changed, 9 insertions(+), 9 deletions(-)
Looks good to me. Thanks for the patch.
Feel free to add -
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
next prev parent reply other threads:[~2023-09-28 8:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 16:03 [PATCH v8 00/12] cleanups and unit test for mballoc Kemeng Shi
2023-09-28 16:03 ` [PATCH v8 01/12] ext4: make state in ext4_mb_mark_bb to be bool Kemeng Shi
2023-09-28 8:31 ` Ritesh Harjani [this message]
2023-09-28 16:03 ` [PATCH v8 02/12] ext4: factor out codes to update block bitmap and group descriptor on disk from ext4_mb_mark_bb Kemeng Shi
2023-09-28 16:03 ` [PATCH v8 03/12] ext4: call ext4_mb_mark_context in ext4_free_blocks_simple Kemeng Shi
2023-09-28 16:03 ` [PATCH v8 04/12] ext4: extend ext4_mb_mark_context to support allocation under journal Kemeng Shi
2023-09-28 16:04 ` [PATCH v8 05/12] ext4: call ext4_mb_mark_context in ext4_mb_mark_diskspace_used Kemeng Shi
2023-09-28 16:04 ` [PATCH v8 06/12] ext4: Separate block bitmap and buddy bitmap freeing in ext4_mb_clear_bb() Kemeng Shi
2023-09-28 16:04 ` [PATCH v8 07/12] ext4: call ext4_mb_mark_context in ext4_mb_clear_bb Kemeng Shi
2023-09-28 16:04 ` [PATCH v8 08/12] ext4: Separate block bitmap and buddy bitmap freeing in ext4_group_add_blocks() Kemeng Shi
2023-09-28 16:04 ` [PATCH v8 09/12] ext4: call ext4_mb_mark_context " Kemeng Shi
2023-09-28 16:04 ` [PATCH v8 10/12] ext4: add some kunit stub for mballoc kunit test Kemeng Shi
2023-09-28 16:04 ` [PATCH v8 11/12] ext4: add first unit test for ext4_mb_new_blocks_simple in mballoc Kemeng Shi
2023-09-28 16:04 ` [PATCH v8 12/12] ext4: run mballoc test with different layouts setting Kemeng Shi
2023-10-06 18:06 ` [PATCH v8 00/12] cleanups and unit test for mballoc Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msx6r95l.fsf@doe.com \
--to=ritesh.list@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=shikemeng@huaweicloud.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox