From: Thomas Gleixner <tglx@linutronix.de>
To: Wei Gong <gongwei833x@gmail.com>
Cc: linux-kernel@vger.kernel.org, Wei Gong <gongwei833x@gmail.com>
Subject: Re: [PATCH v2] genirq: avoid long loops in handle_edge_irq
Date: Tue, 26 Sep 2023 14:28:21 +0200 [thread overview]
Message-ID: <87msx9f7a2.ffs@tglx> (raw)
In-Reply-To: <20230925025154.37959-1-gongwei833x@gmail.com>
On Mon, Sep 25 2023 at 10:51, Wei Gong wrote:
> diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
> index dc94e0bf2c94..6da455e1a692 100644
> --- a/kernel/irq/chip.c
> +++ b/kernel/irq/chip.c
> @@ -831,7 +831,8 @@ void handle_edge_irq(struct irq_desc *desc)
> handle_irq_event(desc);
>
> } while ((desc->istate & IRQS_PENDING) &&
> - !irqd_irq_disabled(&desc->irq_data));
> + !irqd_irq_disabled(&desc->irq_data) &&
> + cpumask_test_cpu(smp_processor_id(), irq_data_get_affinity_mask(&desc->irq_data)));
Assume affinty mask has CPU0 and CPU1 set and the loop is on CPU0, but
the effective affinity is on CPU1 then how is this going to move the
interrupt?
Thanks,
tglx
next prev parent reply other threads:[~2023-09-26 16:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 2:51 [PATCH v2] genirq: avoid long loops in handle_edge_irq Wei Gong
2023-09-26 12:28 ` Thomas Gleixner [this message]
2023-09-27 7:53 ` Wei Gong
2023-09-27 15:25 ` Thomas Gleixner
2023-09-28 2:22 ` Wei Gong
2023-09-28 9:28 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msx9f7a2.ffs@tglx \
--to=tglx@linutronix.de \
--cc=gongwei833x@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).