From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D5E1C04A6A for ; Thu, 10 Aug 2023 17:31:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234525AbjHJRbS (ORCPT ); Thu, 10 Aug 2023 13:31:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbjHJRbR (ORCPT ); Thu, 10 Aug 2023 13:31:17 -0400 Received: from mail.parknet.co.jp (mail.parknet.co.jp [210.171.160.6]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F15172132; Thu, 10 Aug 2023 10:31:16 -0700 (PDT) Received: from ibmpc.myhome.or.jp (server.parknet.ne.jp [210.171.168.39]) by mail.parknet.co.jp (Postfix) with ESMTPSA id 88944205DB99; Fri, 11 Aug 2023 02:31:16 +0900 (JST) Received: from devron.myhome.or.jp (foobar@devron.myhome.or.jp [192.168.0.3]) by ibmpc.myhome.or.jp (8.17.2/8.17.2/Debian-1) with ESMTPS id 37AHVFWc264049 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 11 Aug 2023 02:31:16 +0900 Received: from devron.myhome.or.jp (foobar@localhost [127.0.0.1]) by devron.myhome.or.jp (8.17.2/8.17.2/Debian-1) with ESMTPS id 37AHVFXB402800 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 11 Aug 2023 02:31:15 +0900 Received: (from hirofumi@localhost) by devron.myhome.or.jp (8.17.2/8.17.2/Submit) id 37AHVFbi402799; Fri, 11 Aug 2023 02:31:15 +0900 From: OGAWA Hirofumi To: Jeff Layton Cc: Christian Brauner , Frank Sorenson , Jan Kara , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 2/2] fat: make fat_update_time get its own timestamp In-Reply-To: <20230810-ctime-fat-v1-2-327598fd1de8@kernel.org> (Jeff Layton's message of "Thu, 10 Aug 2023 09:12:05 -0400") References: <20230810-ctime-fat-v1-0-327598fd1de8@kernel.org> <20230810-ctime-fat-v1-2-327598fd1de8@kernel.org> Date: Fri, 11 Aug 2023 02:31:15 +0900 Message-ID: <87msyyn6sc.fsf@mail.parknet.co.jp> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jeff Layton writes: > In later patches, we're going to drop the "now" parameter from the > update_time operation. Fix fat_update_time to fetch its own timestamp. > It turns out that this is easily done by just passing a NULL timestamp > pointer to fat_truncate_time. > > Signed-off-by: Jeff Layton Acked-by: OGAWA Hirofumi Thanks. > --- > fs/fat/misc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/fat/misc.c b/fs/fat/misc.c > index 37f4afb346af..f2304a1054aa 100644 > --- a/fs/fat/misc.c > +++ b/fs/fat/misc.c > @@ -347,7 +347,7 @@ int fat_update_time(struct inode *inode, int flags) > return 0; > > if (flags & (S_ATIME | S_CTIME | S_MTIME)) { > - fat_truncate_time(inode, now, flags); > + fat_truncate_time(inode, NULL, flags); > if (inode->i_sb->s_flags & SB_LAZYTIME) > dirty_flags |= I_DIRTY_TIME; > else -- OGAWA Hirofumi