public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Carlos Bilbao <carlos.bilbao@amd.com>, ojeda@kernel.org
Cc: jani.nikula@linux.intel.com, rdunlap@infradead.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	konstantin@linuxfoundation.org, rust-for-linux@vger.kernel.org,
	Carlos Bilbao <carlos.bilbao@amd.com>
Subject: Re: [PATCH v8 0/2] docs: Integrate rustdoc into Rust documentation
Date: Thu, 20 Jul 2023 16:46:59 -0600	[thread overview]
Message-ID: <87mszqfbfg.fsf@meer.lwn.net> (raw)
In-Reply-To: <20230718151534.4067460-1-carlos.bilbao@amd.com>

Carlos Bilbao <carlos.bilbao@amd.com> writes:

> Include HTML output generated with rustdoc into the Linux kernel
> documentation on Rust.
>
> Carlos Bilbao:
>  docs: Move rustdoc output, cross-reference it
>  docs: Integrate rustdoc generation into htmldocs

So I've been messing with this a bit, trying the various combinations.

- With no .config file, it behaves as it always did - thanks.

- With CONFIG_RUST=y I get the rustdocs, as expected.  There is a time
  penalty of about 5%, which is unfortunate, but that's the cost of
  progress, I guess.

- Setting CONFIG_RUST=n led to a crash with make complaining:
  "No rule to make target 'rustdoc'".  That isn't something I have been
  able to reproduce, though, so I have no idea what happened there; have
  you ever seen this?

Other than that one bit of strangeness, I think this is about ready to
be applied.

Thanks,

jon

  parent reply	other threads:[~2023-07-20 22:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-18 15:15 [PATCH v8 0/2] docs: Integrate rustdoc into Rust documentation Carlos Bilbao
2023-07-18 15:15 ` [PATCH v8 1/2] docs: Move rustdoc output, cross-reference it Carlos Bilbao
2023-07-19 17:19   ` Martin Rodriguez Reboredo
2023-07-20 19:07   ` Miguel Ojeda
2023-07-18 15:15 ` [PATCH v8 2/2] docs: Integrate rustdoc generation into htmldocs Carlos Bilbao
2023-07-19 17:20   ` Martin Rodriguez Reboredo
2023-07-20 22:46 ` Jonathan Corbet [this message]
2023-07-21 21:43   ` [PATCH v8 0/2] docs: Integrate rustdoc into Rust documentation Jonathan Corbet
2023-07-31 14:15   ` Carlos Bilbao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mszqfbfg.fsf@meer.lwn.net \
    --to=corbet@lwn.net \
    --cc=carlos.bilbao@amd.com \
    --cc=jani.nikula@linux.intel.com \
    --cc=konstantin@linuxfoundation.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=rust-for-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox