From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65119C7EE23 for ; Mon, 5 Jun 2023 07:47:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230263AbjFEHrl (ORCPT ); Mon, 5 Jun 2023 03:47:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230415AbjFEHrV (ORCPT ); Mon, 5 Jun 2023 03:47:21 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C45ACE9 for ; Mon, 5 Jun 2023 00:47:20 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 829B21F8AB; Mon, 5 Jun 2023 07:47:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1685951239; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fXACBDWrWpm21SDboD4jk6Mj+IB2S3VWoHaVLLVQuEU=; b=xFJwyLsUXGZJhbw1lihTbO6nRG4gpH5nmhFu3RUjiS+NAMuiZu2x1IKsI11W/hEDy93OhV py+Nkhw9ZiwslZa0bffGAftmHdp06YERIn6E87w/wbJBa+2MdIcNTfzC1GyM9B6n1ZOixU 9N2NS2wNnaZdLCI5PVHOo5rQ4qs5O+g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1685951239; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fXACBDWrWpm21SDboD4jk6Mj+IB2S3VWoHaVLLVQuEU=; b=upxesWqb19z56yRorzmCgNUorCU652+EbD50n18d67+r1HO8rZ5GrEx24uk4Klzdvg99Vr i95wtvV/usGwMTDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 53595139C7; Mon, 5 Jun 2023 07:47:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id rRBLEweTfWTmdAAAMHmgww (envelope-from ); Mon, 05 Jun 2023 07:47:19 +0000 Date: Mon, 05 Jun 2023 09:47:18 +0200 Message-ID: <87mt1eic55.wl-tiwai@suse.de> From: Takashi Iwai To: Cc: Richard Fitzgerald , , , , , Subject: Re: [PATCH v4 00/12] ALSA: hda: Adding support for CS35L56 on HDA systems In-Reply-To: <87o7luic7c.wl-tiwai@suse.de> References: <20230601154731.3210572-1-rf@opensource.cirrus.com> <87o7luic7c.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 05 Jun 2023 09:45:59 +0200, Takashi Iwai wrote: > > On Thu, 01 Jun 2023 17:47:19 +0200, > Richard Fitzgerald wrote: > > > > This set of patches adds support for using the CS35L56 boosted smart > > amplifier on HDA systems. In these systems the CS35L56 audio is > > routed through a HDA-to-I2S bridge codec. > > > > This doesn't include the changes to the Realtek driver to actually hook > > up the CS35L56 driver, because we don't yet have the QUIRK IDs to > > associate it with. But we want to publish the driver now so that it is > > available for bringing up hardware with the CS35L56. > > > > The first 9 patches are moving code out of the ASoC driver and into the > > shared library so that it can be shared with the HDA driver. > > > > Patch #10 fixes missing #includes in the HDA headers so that the CS35L56 > > driver doesn't have to #include headers that it doesn't use. > > > > Finally, #11 and #12 actually add the support for CS35L56 on HDA. > > > > CHANGES SINCE V3 > > Patch 01: > > - Fix double-free of IRQ caused by passing wrong cookie to devm_irq_free() > > Patch 12: > > - Fix memory leak of struct firmware object and firmware name strings. > > - Find and open firmware files before taking the irq_lock mutex and pm_runtime. > > - Don't bother executing the firmware loading code if no firmware files were > > found. > > > > Richard Fitzgerald (4): > > ASoC: cs35l56: Move runtime suspend/resume to shared library > > ASoC: cs35l56: Move cs_dsp init into shared library > > ASoC: cs35l56: Move part of cs35l56_init() to shared library > > ALSA: hda: Fix missing header dependencies > > > > Simon Trimmer (8): > > ASoC: cs35l56: Move shared data into a common data structure > > ASoC: cs35l56: Make cs35l56_system_reset() code more generic > > ASoC: cs35l56: Convert utility functions to use common data structure > > ASoC: cs35l56: Move utility functions to shared file > > ASoC: cs35l56: Make common function for control port wait > > ASoC: cs35l56: Make a common function to shutdown the DSP > > ALSA: hda: Add mute_hook to hda_component > > ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier > > It'd be likely easier to merge all those via ASoC tree, I suppose, as > some patches seem to have prerequisite in the recent ASoC changes. > So, Mark, could you take those through yours? > > Feel free to put my ack: > > Reviewed-by: Takashi Iwai Oh, and after you merge them, please send a PR to sound.git tree, too. This will make our lives easier, as there will be other conflicting changes for HD-audio component for TAS codecs, too. thanks, Takashi