From: Thomas Gleixner <tglx@linutronix.de>
To: "Rafael J. Wysocki" <rafael@kernel.org>, lirongqing@baidu.com
Cc: mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
x86@kernel.org, rafael@kernel.org, daniel.lezcano@linaro.org,
peterz@infradead.org, akpm@linux-foundation.org,
tony.luck@intel.com, jpoimboe@kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] cpuidle-haltpoll: Disable kvm guest polling when mwait_idle is used
Date: Tue, 06 Dec 2022 13:08:10 +0100 [thread overview]
Message-ID: <87mt80g2fp.ffs@tglx> (raw)
In-Reply-To: <CAJZ5v0gG93BXZWOcRVpng_EN-h4+sOyUqTc1XRt4xZkqMnaZZw@mail.gmail.com>
On Tue, Dec 06 2022 at 12:59, Rafael J. Wysocki wrote:
> On Tue, Dec 6, 2022 at 7:43 AM <lirongqing@baidu.com> wrote:
>>
>> +bool is_mwait_idle(void)
>> +{
>> + return x86_idle == mwait_idle;
>> +}
>> +EXPORT_SYMBOL_GPL(is_mwait_idle);
No, this is just another adhoc check, which scratches ONE particular itch.
>> @@ -111,6 +112,9 @@ static int __init haltpoll_init(void)
>> if (!kvm_para_available() || !haltpoll_want())
>> return -ENODEV;
>>
>> + if (is_mwait_idle())
>> + return -ENODEV;
>> +
>
> So perhaps you could make default_enter_idle() be a bit more careful
> about what it calls as the "default idle" routine?
Correct. arch_cpu_idle() is the one which should be called.
Thanks,
tglx
next prev parent reply other threads:[~2022-12-06 12:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 6:43 [PATCH] cpuidle-haltpoll: Disable kvm guest polling when mwait_idle is used lirongqing
2022-12-06 11:59 ` Rafael J. Wysocki
2022-12-06 12:08 ` Thomas Gleixner [this message]
2022-12-07 3:45 ` Li,Rongqing
2022-12-07 10:49 ` Li,Rongqing
2022-12-07 11:41 ` Thomas Gleixner
2022-12-07 12:18 ` Li,Rongqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt80g2fp.ffs@tglx \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=daniel.lezcano@linaro.org \
--cc=dave.hansen@linux.intel.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox