From: Michael Ellerman <mpe@ellerman.id.au>
To: Michael Jeanson <mjeanson@efficios.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Steven Rostedt <rostedt@goodmis.org>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Nicholas Piggin <npiggin@gmail.com>,
Michal Suchanek <msuchanek@suse.de>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: [PATCH] powerpc/ftrace: fix syscall tracing on PPC64_ELF_ABI_V1
Date: Tue, 06 Dec 2022 09:50:08 +1100 [thread overview]
Message-ID: <87mt81sbxb.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <dfe0b9ba-828d-e1a5-f9a3-416c6b5b1cf3@efficios.com>
Michael Jeanson <mjeanson@efficios.com> writes:
> On 2022-12-05 15:11, Michael Jeanson wrote:
>>>>> Michael Jeanson <mjeanson@efficios.com> writes:
>>>>>> In v5.7 the powerpc syscall entry/exit logic was rewritten in C, on
>>>>>> PPC64_ELF_ABI_V1 this resulted in the symbols in the syscall table
>>>>>> changing from their dot prefixed variant to the non-prefixed ones.
>>>>>>
>>>>>> Since ftrace prefixes a dot to the syscall names when matching them to
>>>>>> build its syscall event list, this resulted in no syscall events being
>>>>>> available.
>>>>>>
>>>>>> Remove the PPC64_ELF_ABI_V1 specific version of
>>>>>> arch_syscall_match_sym_name to have the same behavior across all powerpc
>>>>>> variants.
>>>>>
>>>>> This doesn't seem to work for me.
>>>>>
>>>>> Event with it applied I still don't see anything in
>>>>> /sys/kernel/debug/tracing/events/syscalls
>>>>>
>>>>> Did we break it in some other way recently?
>>>>>
>>>>> cheers
>
> I did some further testing, my config also enabled KALLSYMS_ALL, when I remove
> it there is indeed no syscall events.
Aha, OK that explains it I guess.
I was using ppc64_guest_defconfig which has ABI_V1 and FTRACE_SYSCALLS,
but does not have KALLSYMS_ALL. So I guess there's some other bug
lurking in there.
cheers
next prev parent reply other threads:[~2022-12-05 22:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 16:14 [PATCH] powerpc/ftrace: fix syscall tracing on PPC64_ELF_ABI_V1 Michael Jeanson
2022-12-05 5:34 ` Michael Ellerman
2022-12-05 18:19 ` Michael Jeanson
2022-12-05 18:56 ` Christophe Leroy
2022-12-05 20:11 ` Michael Jeanson
2022-12-05 21:46 ` Michael Jeanson
2022-12-05 22:50 ` Michael Ellerman [this message]
2022-12-06 14:38 ` Mathieu Desnoyers
2022-12-06 23:08 ` Christophe Leroy
2022-12-07 2:09 ` Michael Ellerman
2022-12-07 15:18 ` Mathieu Desnoyers
2022-12-07 15:59 ` Michal Suchánek
2022-12-07 16:26 ` Christophe Leroy
2022-12-08 12:40 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt81sbxb.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mjeanson@efficios.com \
--cc=msuchanek@suse.de \
--cc=npiggin@gmail.com \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox