From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5637BC00140 for ; Thu, 18 Aug 2022 13:49:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245249AbiHRNt2 (ORCPT ); Thu, 18 Aug 2022 09:49:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245239AbiHRNtZ (ORCPT ); Thu, 18 Aug 2022 09:49:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 226AA3D586 for ; Thu, 18 Aug 2022 06:49:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B2CF0616EC for ; Thu, 18 Aug 2022 13:49:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E76CC433D6; Thu, 18 Aug 2022 13:49:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660830563; bh=IXFzUYkPxzgfGBkAIA7XymuuI3EYkVxklX6Y1+AO06c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=A0GpfWblTuyAUV49vwUrhrhF4mcdVfGHYDZDT04X4S2rjoL0s1x6pJFKdd7nsI/N+ HJ/AIJIHJXR6v9mbvOWqvmyWbmw89d2BElJA2amdRQcCOwhl23+OZ0tdZ0lU70UeY9 Pdz35+lLOUvsp2E9+x/diqRbPfCErk1CcwcTPcZU09U+YFfAoxKQS43V5I9ZExh85K p5MOC2Oc4xe7sNYPbepV7r+P9id5g8btuHur+z0u/XiKP6xTCEDuQMs7SUrxIoz8Z7 6cte+uNKZhfZZA7smt+3GK1UcMrip6dbhVylakp6PDv6f7UqHrNz6YXLyWPkqeY4we 7E9bu7we+qkOw== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oOftg-00402o-Sp; Thu, 18 Aug 2022 14:49:20 +0100 Date: Thu, 18 Aug 2022 14:49:20 +0100 Message-ID: <87mtc1wtjz.wl-maz@kernel.org> From: Marc Zyngier To: Dmitry Rokosov Cc: "broonie@kernel.org" , "gregkh@linuxfoundation.org" , "rafael@kernel.org" , "jic23@kernel.org" , "linux@rasmusvillemoes.dk>" , "tglx@linutronix.de" , "andy.shevchenko@gmail.com" , kernel , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v1] regmap: introduce value tracing for regmap bulk operations In-Reply-To: <20220818121515.6azkxyqetnunwsc6@CAB-WSD-L081021.sigma.sbrf.ru> References: <20220816181451.5628-1-ddrokosov@sberdevices.ru> <20220818121515.6azkxyqetnunwsc6@CAB-WSD-L081021.sigma.sbrf.ru> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: DDRokosov@sberdevices.ru, broonie@kernel.org, gregkh@linuxfoundation.org, rafael@kernel.org, jic23@kernel.org, linux@rasmusvillemoes.dk, tglx@linutronix.de, andy.shevchenko@gmail.com, kernel@sberdevices.ru, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 18 Aug 2022 13:15:00 +0100, Dmitry Rokosov wrote: > > +Thomas, Rasmus and Marc > > On Tue, Aug 16, 2022 at 06:14:48PM +0000, Dmitry Rokosov wrote: > > Currently, only one-register io operations support tracepoints with > > value logging. For the regmap bulk operations developer can view > > hw_start/hw_done tracepoints with starting reg number and registers > > count to be reading or writing. This patch injects tracepoints with > > dumping registers values in the hex format to regmap bulk reading > > and writing. I don't care much about regmap as a MMIO backend, but it strikes me as odd that you end up with multiple ways of logging the same stuff (with a memcpy in the middle of it). Why can't this be done with a small amount of trace post-processing? M. -- Without deviation from the norm, progress is not possible.