From: Thomas Gleixner <tglx@linutronix.de>
To: Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH v2] x86/apic: Do apic driver probe for "nosmp" use case
Date: Thu, 07 Apr 2022 00:50:56 +0200 [thread overview]
Message-ID: <87mtgxzuzz.ffs@tglx> (raw)
In-Reply-To: <20220406185430.552016-1-sathyanarayanan.kuppuswamy@linux.intel.com>
On Wed, Apr 06 2022 at 18:54, Kuppuswamy Sathyanarayanan wrote:
> diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
> index b70344bf6600..79b8b521981c 100644
> --- a/arch/x86/kernel/apic/apic.c
> +++ b/arch/x86/kernel/apic/apic.c
> @@ -1419,22 +1419,22 @@ void __init apic_intr_mode_init(void)
> return;
> case APIC_VIRTUAL_WIRE:
> pr_info("APIC: Switch to virtual wire mode setup\n");
> - default_setup_apic_routing();
> break;
> case APIC_VIRTUAL_WIRE_NO_CONFIG:
> pr_info("APIC: Switch to virtual wire mode setup with no configuration\n");
> upmode = true;
> - default_setup_apic_routing();
> break;
> case APIC_SYMMETRIC_IO:
> pr_info("APIC: Switch to symmetric I/O mode setup\n");
> - default_setup_apic_routing();
> break;
> case APIC_SYMMETRIC_IO_NO_ROUTING:
> pr_info("APIC: Switch to symmetric I/O mode setup in no SMP routine\n");
> + upmode = true;
Why? The changelog tells nothing about this change.
And it's not correct because the APIC configuration is there, otherwise
__apic_intr_mode_select() would have returned APIC_VIRTUAL_WIRE_NO_CONFIG.
Thanks,
tglx
next prev parent reply other threads:[~2022-04-06 22:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 18:54 [PATCH v2] x86/apic: Do apic driver probe for "nosmp" use case Kuppuswamy Sathyanarayanan
2022-04-06 22:50 ` Thomas Gleixner [this message]
2022-04-08 3:54 ` Sathyanarayanan Kuppuswamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtgxzuzz.ffs@tglx \
--to=tglx@linutronix.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rafael.j.wysocki@intel.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox