Re: [RFC PATCH v4 3/5] gpio: gpiolib: Allow free() callback to be overridden

Lad, Prabhakar
2022-03-18T15:16:15Z

Hi Linus,

On Thu, Mar 17, 2022 at 1:24 AM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
>
> Allow free() callback to be overridden from irq_domain_ops for
> hierarchical chips.
>
> This allows drivers to free any resources which are allocated during
> populate_parent_alloc_arg().
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> drivers/gpio/gpiolib.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
Sorry to ping early, this patch and 4/5 hasn't been reviewed at all in
previous versions. So I wanted to get your feedback before I post an
non -RFC version of the series.

Cheers,
Prabhakar

> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index defb7c464b87..aede442f610d 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -1187,15 +1187,18 @@ static void gpiochip_hierarchy_setup_domain_ops(struct irq_domain_ops *ops)
> ops->activate = gpiochip_irq_domain_activate;
> ops->deactivate = gpiochip_irq_domain_deactivate;
> ops->alloc = gpiochip_hierarchy_irq_domain_alloc;
> - ops->free = irq_domain_free_irqs_common;
>
> /*
> - * We only allow overriding the translate() function for
> + * We only allow overriding the translate() and free() function for
> * hierarchical chips, and this should only be done if the user
> - * really need something other than 1:1 translation.
> + * really need something other than 1:1 translation for translate()
> + * callback and free if user wants to free up any resources which
> + * were allocated during callbacks for example populate_parent_alloc_arg.
> */
> if (!ops->translate)
> ops->translate = gpiochip_hierarchy_irq_domain_translate;
> + if (!ops->free)
> + ops->free = irq_domain_free_irqs_common;
> }
>
> static int gpiochip_hierarchy_add_domain(struct gpio_chip *gc)
> --
> 2.17.1
>