Re: [patch V3 01/35] PCI/MSI: Set pci_dev::msi[x]_enabled early

Jason Gunthorpe
2021-12-13T13:37:42Z

On Fri, Dec 10, 2021 at 11:18:44PM +0100, Thomas Gleixner wrote:
> There are quite some places which retrieve the first MSI descriptor to
> evaluate whether the setup is for MSI or MSI-X. That's required because
> pci_dev::msi[x]_enabled is only set when the setup completed successfully.
>
> There is no real reason why msi[x]_enabled can't be set at the beginning of
> the setup sequence and cleared in case of a failure.
>
> Implement that so the MSI descriptor evaluations can be converted to simple
> property queries.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
> V3: New patch
> ---
> drivers/pci/msi/msi.c | 23 +++++++++++++++++------
> 1 file changed, 17 insertions(+), 6 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason