From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 273D4C4707A for ; Sun, 23 May 2021 10:51:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 03A2F610CE for ; Sun, 23 May 2021 10:51:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231708AbhEWKwn (ORCPT ); Sun, 23 May 2021 06:52:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231679AbhEWKwn (ORCPT ); Sun, 23 May 2021 06:52:43 -0400 Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B130EC061574 for ; Sun, 23 May 2021 03:51:16 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4FnxwH754hz9sRN; Sun, 23 May 2021 20:51:11 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1621767072; bh=X4NtLMivf9OnS/Dpei3UYlbkelZal2VO/5jUSAl6Krs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=apJpFz3oTrM1TCz5/jKU78KvIO5bPBBdqh9BIizd3LavEzQu4aBuFN1AY17K7yWtc 5Ys5HZuq4tIcylMjvwrjriWbEpER2Sh1fG26L4/w5A2HKxUgfU/yqB/wcYgw53sYaC creV/kfLL0JbdpstR0krx5/Qy+gTTKWvPem7Mls/87DAvzu4ZuTKSsDWnpryu4Ak+t CDrkcPA3iMnqUegZ1kx9QPdQBWUIlTBxpoR7qUiOmFg83BOm3OYgXJ9oAAVXtnHCJQ pI/FbKnQTyJZenWSJW3wW0JNbYTZXIhx2OT8lSdGeMDrLGVg01PyKZx6K1p2OBbjQI 9oX9MN8EN8Y0w== From: Michael Ellerman To: Greg KH , Nathan Lynch Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, jirislaby@kernel.org Subject: Re: [PATCH] powerpc/udbg_hvc: retry putc on -EAGAIN In-Reply-To: References: <20210514214422.3019105-1-nathanl@linux.ibm.com> Date: Sun, 23 May 2021 20:51:09 +1000 Message-ID: <87mtsliuzm.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg KH writes: > On Fri, May 14, 2021 at 04:44:22PM -0500, Nathan Lynch wrote: >> hvterm_raw_put_chars() calls hvc_put_chars(), which may return -EAGAIN >> when the underlying hcall returns a "busy" status, but udbg_hvc_putc() >> doesn't handle this. When using xmon on a PowerVM guest, this can >> result in incomplete or garbled output when printing relatively large >> amounts of data quickly, such as when dumping the kernel log buffer. >> >> Call again on -EAGAIN. >> >> Signed-off-by: Nathan Lynch >> --- >> drivers/tty/hvc/hvc_vio.c | 2 +- > > Subject line does not match up with this file name. > > Don't you want "tty" and "hvc" in there somewhere? It's a powerpc only driver, but I guess the subject should still be "tty: hvc: ..." to match convention. I was planning to take this via the powerpc tree, but I can drop it if you'd rather take it. cheers