From: Kalle Valo <kvalo@codeaurora.org>
To: Tony Chuang <yhchuang@realtek.com>
Cc: Nathan Chancellor <natechancellor@gmail.com>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"clang-built-linux\@googlegroups.com"
<clang-built-linux@googlegroups.com>
Subject: Re: [PATCH] rtw88: Initialize ret in rtw_wow_check_fw_status
Date: Fri, 31 Jan 2020 13:03:48 +0200 [thread overview]
Message-ID: <87mua3c2gb.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <e0fb1ead6dcc4ecc973b3b9b5399ef66@realtek.com> (Tony Chuang's message of "Fri, 31 Jan 2020 10:23:40 +0000")
Tony Chuang <yhchuang@realtek.com> writes:
> From: Nathan Chancellor
>> Subject: [PATCH] rtw88: Initialize ret in rtw_wow_check_fw_status
>>
>> Clang warns a few times (trimmed for brevity):
>>
>> ../drivers/net/wireless/realtek/rtw88/wow.c:295:7: warning: variable
>> 'ret' is used uninitialized whenever 'if' condition is false
>> [-Wsometimes-uninitialized]
>>
>> Initialize ret to true and change the other assignments to false because
>> it is a boolean value.
>>
>> Fixes: 44bc17f7f5b3 ("rtw88: support wowlan feature for 8822c")
>> Link: https://github.com/ClangBuiltLinux/linux/issues/850
>> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
>> ---
>> drivers/net/wireless/realtek/rtw88/wow.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/wireless/realtek/rtw88/wow.c
>> b/drivers/net/wireless/realtek/rtw88/wow.c
>> index af5c27e1bb07..5db49802c72c 100644
>> --- a/drivers/net/wireless/realtek/rtw88/wow.c
>> +++ b/drivers/net/wireless/realtek/rtw88/wow.c
>> @@ -283,18 +283,18 @@ static void rtw_wow_rx_dma_start(struct rtw_dev
>> *rtwdev)
>>
>> static bool rtw_wow_check_fw_status(struct rtw_dev *rtwdev, bool
>> wow_enable)
>> {
>> - bool ret;
>> + bool ret = true;
>>
>> /* wait 100ms for wow firmware to finish work */
>> msleep(100);
>>
>> if (wow_enable) {
>> if (!rtw_read8(rtwdev, REG_WOWLAN_WAKE_REASON))
>> - ret = 0;
>> + ret = false;
>> } else {
>> if (rtw_read32_mask(rtwdev, REG_FE1IMR, BIT_FS_RXDONE) == 0
>> &&
>> rtw_read32_mask(rtwdev, REG_RXPKT_NUM,
>> BIT_RW_RELEASE) == 0)
>> - ret = 0;
>> + ret = false;
>> }
>>
>> if (ret)
>> --
>> 2.25.0
>
> NACK.
>
> This patch could lead to incorrect behavior of WOW.
> I will send a new patch to fix it, and change the type to "int".
Please send it separately so that I can queue it to v5.6.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-01-31 11:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 1:33 [PATCH] rtw88: Initialize ret in rtw_wow_check_fw_status Nathan Chancellor
2020-01-31 10:23 ` Tony Chuang
2020-01-31 11:03 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mua3c2gb.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox