Re: [PATCH] powerpc/mm/32s: only use MMU to mark initmem NX if STRICT_KERNEL_RWX

christophe leroy
2019-06-16T08:21:21Z

Le 15/06/2019 à 16:36, Andreas Schwab a écrit :
> On Jun 15 2019, Christophe Leroy <christophe.leroy@c-s.fr> wrote:
>
>> Andreas Schwab <schwab@linux-m68k.org> a écrit :
>>
>>> If STRICT_KERNEL_RWX is disabled, never use the MMU to mark initmen
>>> nonexecutable.
>>
>> I dont understand, can you elaborate ?
>
> It breaks suspend.

Ok, but we need to explain why it breaks suspend, and again your patch
is wrong anyway because that area of memory is mapped with BATs so you
can't use change_page_attr()

>
>> This area is mapped with BATs so using change_page_attr() is pointless.
>
> There must be a reason STRICT_KERNEL_RWX is not available with
> HIBERNATE.

Yes but HIBERNATE and suspend are not the same thing. I guess HIBERNATE
is not available with STRICT_KERNEL_RWX because HIBERNATE have to write
back saved state into read-only memory as well.

Christophe

---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.