From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0E5CC43144 for ; Thu, 28 Jun 2018 05:35:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB3AC2620E for ; Thu, 28 Jun 2018 05:35:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB3AC2620E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933038AbeF1FfU (ORCPT ); Thu, 28 Jun 2018 01:35:20 -0400 Received: from mga01.intel.com ([192.55.52.88]:58187 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752962AbeF1FfS (ORCPT ); Thu, 28 Jun 2018 01:35:18 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2018 22:35:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,282,1526367600"; d="scan'208";a="60754453" Received: from yhuang-dev.sh.intel.com (HELO yhuang-dev) ([10.239.13.118]) by FMSMGA003.fm.intel.com with ESMTP; 27 Jun 2018 22:35:16 -0700 From: "Huang\, Ying" To: Andrew Morton Cc: , , Hugh Dickins , "Kirill A. Shutemov" , Daniel Jordan Subject: Re: [PATCH -mm -v4 00/21] mm, THP, swap: Swapout/swapin THP in one piece References: <20180622035151.6676-1-ying.huang@intel.com> <20180627215144.73e98b01099191da59bff28c@linux-foundation.org> <87r2krfpi2.fsf@yhuang-dev.intel.com> <20180627223118.dd2f52d87f53e7e002ed0153@linux-foundation.org> Date: Thu, 28 Jun 2018 13:35:15 +0800 In-Reply-To: <20180627223118.dd2f52d87f53e7e002ed0153@linux-foundation.org> (Andrew Morton's message of "Wed, 27 Jun 2018 22:31:18 -0700") Message-ID: <87muvffp7w.fsf@yhuang-dev.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrew Morton writes: > On Thu, 28 Jun 2018 13:29:09 +0800 "Huang\, Ying" wrote: > >> Andrew Morton writes: >> >> > On Fri, 22 Jun 2018 11:51:30 +0800 "Huang, Ying" wrote: >> > >> >> This is the final step of THP (Transparent Huge Page) swap >> >> optimization. After the first and second step, the splitting huge >> >> page is delayed from almost the first step of swapout to after swapout >> >> has been finished. In this step, we avoid splitting THP for swapout >> >> and swapout/swapin the THP in one piece. >> > >> > It's a tremendously good performance improvement. It's also a >> > tremendously large patchset :( >> > >> > And it depends upon your >> > mm-swap-fix-race-between-swapoff-and-some-swap-operations.patch and >> > mm-fix-race-between-swapoff-and-mincore.patch, the first of which has >> > been floating about since February without adequate review. >> > >> > I'll give this patchset a spin in -mm to see what happens and will come >> > back later to take a closer look. But the best I can do at this time >> > is to hopefully cc some possible reviewers :) >> >> Thanks a lot for your help! Hope more people can review it! > > I took it out of -mm again, temporarily. Due to a huge tangle with the > xarray conversions in linux-next. No problem. I will rebase the patchset on your latest -mm tree, or the next version to be released? Best Regards, Huang, Ying