From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4E30C43141 for ; Wed, 20 Jun 2018 17:17:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9DE7520846 for ; Wed, 20 Jun 2018 17:17:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DE7520846 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=free.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932442AbeFTRRr (ORCPT ); Wed, 20 Jun 2018 13:17:47 -0400 Received: from smtp06.smtpout.orange.fr ([80.12.242.128]:32221 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932154AbeFTRRp (ORCPT ); Wed, 20 Jun 2018 13:17:45 -0400 Received: from belgarion ([90.55.203.186]) by mwinf5d64 with ME id 15Hj1y00W41oiFu035Hjib; Wed, 20 Jun 2018 19:17:44 +0200 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Wed, 20 Jun 2018 19:17:44 +0200 X-ME-IP: 90.55.203.186 From: Robert Jarzmik To: "David S. Miller" Cc: Daniel Mack , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v3 07/14] net: smc911x: remove the dmaengine compat need References: <20180617170217.24177-1-robert.jarzmik@free.fr> <20180617170217.24177-8-robert.jarzmik@free.fr> X-URL: http://belgarath.falguerolles.org/ Date: Wed, 20 Jun 2018 19:17:43 +0200 In-Reply-To: <20180617170217.24177-8-robert.jarzmik@free.fr> (Robert Jarzmik's message of "Sun, 17 Jun 2018 19:02:10 +0200") Message-ID: <87muvppebs.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David, I have converted all the pxa related drivers to DMA slave maps, the only 2 that remain in my queue are touching your tree, ie. smc911x and smc91x (see [1]). Once these 2 are done, I have my last dependency on the dma filter function removed, and can queue the remaining cleanup patches. Could you (or somebody from netdev) review it and either ack it (and I'll take it through the pxa tree), or take it for v4.19 please ? Cheers. -- Robert [1] Submission Robert Jarzmik writes: > As the pxa architecture switched towards the dmaengine slave map, the > old compatibility mechanism to acquire the dma requestor line number and > priority are not needed anymore. > > This patch simplifies the dma resource acquisition, using the more > generic function dma_request_slave_channel(). > > Signed-off-by: Robert Jarzmik > --- > Since v2: converted to NULL filter function and NULL dma parameter call > --- > drivers/net/ethernet/smsc/smc911x.c | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) > > diff --git a/drivers/net/ethernet/smsc/smc911x.c b/drivers/net/ethernet/smsc/smc911x.c > index 05157442a980..b1b53f6c452f 100644 > --- a/drivers/net/ethernet/smsc/smc911x.c > +++ b/drivers/net/ethernet/smsc/smc911x.c > @@ -74,7 +74,6 @@ static const char version[] = > #include > > #include > -#include > > #include > > @@ -1795,7 +1794,6 @@ static int smc911x_probe(struct net_device *dev) > #ifdef SMC_USE_DMA > struct dma_slave_config config; > dma_cap_mask_t mask; > - struct pxad_param param; > #endif > > DBG(SMC_DEBUG_FUNC, dev, "--> %s\n", __func__); > @@ -1971,15 +1969,8 @@ static int smc911x_probe(struct net_device *dev) > > dma_cap_zero(mask); > dma_cap_set(DMA_SLAVE, mask); > - param.prio = PXAD_PRIO_LOWEST; > - param.drcmr = -1UL; > - > - lp->rxdma = > - dma_request_slave_channel_compat(mask, pxad_filter_fn, > - ¶m, &dev->dev, "rx"); > - lp->txdma = > - dma_request_slave_channel_compat(mask, pxad_filter_fn, > - ¶m, &dev->dev, "tx"); > + lp->rxdma = dma_request_channel(mask, NULL, NULL); > + lp->txdma = dma_request_channel(mask, NULL, NULL); > lp->rxdma_active = 0; > lp->txdma_active = 0; -- Robert