Re: [PATCH] USB :core :Prevent USB devices to autosuspend while setting interface

[Felipe Balbi <felipe.balbi@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]


Hi,

Abhijeet@vger.kernel.org, Kumar@vger.kernel.org writes:

these emails don't exist. Fix your email client.

> From: abhijeet kumar <abhijeet.kumar@intel.com>

capitalize names

> Runtime resume USB device in order to ensure that PM framework
> knows that the we might be using the device in a short time and doesn't
> autosuspend the device while we updating it's interface.

this doesn't tell me about any problem. What, exactly, are you trying to
fix?

> Signed-off-by: abhijeet kumar <abhijeet.kumar@intel.com>

capitalize names

> diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
> index 371a07d874a3..658603ed779e 100644
> --- a/drivers/usb/core/message.c
> +++ b/drivers/usb/core/message.c
> @@ -1305,6 +1305,9 @@ int usb_set_interface(struct usb_device *dev, int interface, int alternate)
>  	if (iface->unregistering)
>  		return -ENODEV;
>  
> +	/*Letting runtime PM now that we wish to use the device in a short time
> +	 *pm_runtime_get(&iface->dev);
> +	 */

why is it so that adding commented out code help? Did you *really* test
this at all?

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]