From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752697AbdKJMy5 (ORCPT ); Fri, 10 Nov 2017 07:54:57 -0500 Received: from mga05.intel.com ([192.55.52.43]:41606 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751095AbdKJMy4 (ORCPT ); Fri, 10 Nov 2017 07:54:56 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,374,1505804400"; d="asc'?scan'208";a="546292" From: Felipe Balbi To: Abhijeet@vger.kernel.org, Kumar@vger.kernel.org, Greg Kroah-Hartman , abhijeet kumar , Jaejoong Kim , Mauro Carvalho Chehab , Jonathan Corbet , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB :core :Prevent USB devices to autosuspend while setting interface In-Reply-To: <1510318190-25180-1-git-send-email-abhijeet.kumar@intel.com> References: <1510318190-25180-1-git-send-email-abhijeet.kumar@intel.com> Date: Fri, 10 Nov 2017 14:54:49 +0200 Message-ID: <87mv3ue1k6.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Abhijeet@vger.kernel.org, Kumar@vger.kernel.org writes: these emails don't exist. Fix your email client. > From: abhijeet kumar capitalize names > Runtime resume USB device in order to ensure that PM framework > knows that the we might be using the device in a short time and doesn't > autosuspend the device while we updating it's interface. this doesn't tell me about any problem. What, exactly, are you trying to fix? > Signed-off-by: abhijeet kumar capitalize names > diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c > index 371a07d874a3..658603ed779e 100644 > --- a/drivers/usb/core/message.c > +++ b/drivers/usb/core/message.c > @@ -1305,6 +1305,9 @@ int usb_set_interface(struct usb_device *dev, int i= nterface, int alternate) > if (iface->unregistering) > return -ENODEV; >=20=20 > + /*Letting runtime PM now that we wish to use the device in a short time > + *pm_runtime_get(&iface->dev); > + */ why is it so that adding commented out code help? Did you *really* test this at all? =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAloFoZkACgkQzL64meEa mQYNVA//cCz1cPbnl4kMBouYI4pJSn5hvvUmqZLVRteYNYv8aIQubhMG3/KU05bs GXYAkqD2uS2xsA1QHsqEiK9uvLahaJm/zzn5t+2yTKToGxKByGOWssUENX2fADRT JVx80iz58uBAlc1DqbNQwWknC00VSHVxmPSC2Sxkal8PWhSddWdrg06CA3ljU9sH VrNy4kVaGk26j/geki4+3Z8yMycdMLjuXxptWGXmjPrJnEDrKmB2zEmvsDlohl2W 2pBlMYy9WbcrZi5Zdkuev+Is+tBc5AFN6yw8jhkDYC3pJR5zP1e76zNuSlf/uC0R JgYxX0RAgo7wJBBruSqvZN1okJS3f7WAVYCJyhLpG+Pws9pCQ6z6kW+It11FSwm/ xhjP+8Uc9tF2SECMhJyVP12KBWNpMIxkRC0i2u+FPdKUF/Ewujf4o5XQCWbhRIis uGaaAERo3ubgaXPsyUgZyVFpT+H7VP6ycoBKI3oKwrcQz41cCOiW5oF2gOuhqt37 xzDMx1oH61j9HLWg542LRHsGiNe5/ZJ2OoBEY2puiQ0YDiQ1RjUmak8DIwx+Z7XC Gl/oMD/UQJK3S2hxO/O/7SNdpigKUAzgMzMTopjkLMDvCWu3SXMBOtCSt2Wiy8II RquzH/M4YCsGzMwA2BltJbdkwKzUEvETUgZFZxwz/NblcT1O3r8= =O/bk -----END PGP SIGNATURE----- --=-=-=--