From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933763AbdKBPXr (ORCPT <rfc822;w@1wt.eu>);
        Thu, 2 Nov 2017 11:23:47 -0400
Received: from sabertooth01.qualcomm.com ([65.197.215.72]:46704 "EHLO
        sabertooth01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933418AbdKBPXp (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 2 Nov 2017 11:23:45 -0400
X-IronPort-AV: E=Sophos;i="5.44,334,1505804400"; 
   d="scan'208";a="116387911"
X-IronPort-AV: E=McAfee;i="5900,7806,8702"; a="1525717657"
X-MGA-submission: =?us-ascii?q?MDHK7kvN9UmRQwqP/85uUvQb5iPG+fnfd0pebr?=
 =?us-ascii?q?NgKxWfNp1SFuVM2ZK4Sa+ZYQSIseYfIJT55VTlnswMIriTKPedAu7lDn?=
 =?us-ascii?q?7lQhZuaoyhF2Ean/wGbOh34oSwFjh5bdJLgXAa8gk5PRfgsMvGV65DP7?=
 =?us-ascii?q?oD?=
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Arnd Bergmann <arnd@arndb.de>
CC: Ryan Hsu <ryanhsu@qti.qualcomm.com>,
        Govind Singh <govinds@qti.qualcomm.com>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Ashok Raj Nagarajan <arnagara@qti.qualcomm.com>,
        Ben Greear <greearb@candelatech.com>,
        "Brian Norris" <briannorris@chromium.org>,
        Colin Ian King <colin.king@canonical.com>,
        "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ath10k: move pci suspend/resume functions
Thread-Topic: [PATCH] ath10k: move pci suspend/resume functions
Thread-Index: AQHTU8sIUwjYYm0/ZUGKqAY2G2HYKA==
Date: Thu, 2 Nov 2017 15:23:42 +0000
Message-ID: <87mv44ln5v.fsf@qca.qualcomm.com>
References: <20171102110903.2886660-1-arnd@arndb.de>
In-Reply-To: <20171102110903.2886660-1-arnd@arndb.de> (Arnd Bergmann's message
        of "Thu, 2 Nov 2017 12:08:53 +0100")
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [199.106.107.6]
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vA2FNp0B011028

Arnd Bergmann <arnd@arndb.de> writes:

> The combination of two patches has led to a build failure:
>
> drivers/net/wireless/ath/ath10k/pci.c: In function 'ath10k_pci_pm_suspend':
> drivers/net/wireless/ath/ath10k/pci.c:3416:8: error: implicit declaration of function 'ath10k_pci_suspend'; did you mean 'ath10k_pci_pm_suspend'? [-Werror=implicit-function-declaration]
> drivers/net/wireless/ath/ath10k/pci.c: In function 'ath10k_pci_pm_resume':
> drivers/net/wireless/ath/ath10k/pci.c:3428:8: error: implicit declaration of function 'ath10k_pci_resume'; did you mean 'ath10k_pci_pm_resume'? [-Werror=implicit-function-declaration]
>
> This moves the functions outside of the now incorrect #ifdef.
>
> Fixes: 96378bd2c6cd ("ath10k: fix core PCI suspend when WoWLAN is supported but disabled")
> Fixes: 6af1de2e4ec4 ("ath10k: mark PM functions as __maybe_unused")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Brian has already fixed this, please check that:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=ath-next&id=20665a9076d48e9abd9a2db13d307f58f7ef6647

But apparently I forgot to merge ath-next to wireless-drivers-next, will
do that soon.

-- 
Kalle Valo