From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752024AbdGYMwH (ORCPT ); Tue, 25 Jul 2017 08:52:07 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:51470 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751897AbdGYMwF (ORCPT ); Tue, 25 Jul 2017 08:52:05 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C16D66073F Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Arnd Bergmann Cc: x86@kernel.org, Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Subject: Re: [RFC 2/2] wl3501_cs: reduce stack size for KASAN References: <20170710144425.2238584-1-arnd@arndb.de> <20170710144425.2238584-2-arnd@arndb.de> Date: Tue, 25 Jul 2017 15:52:00 +0300 In-Reply-To: <20170710144425.2238584-2-arnd@arndb.de> (Arnd Bergmann's message of "Mon, 10 Jul 2017 16:44:25 +0200") Message-ID: <87mv7sisr3.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann writes: > Inlining functions with local variables can lead to excessive stack usage > with KASAN after a previous patch that modifies the outsb/insb helpers > on x86. > > drivers/net/wireless/wl3501_cs.c: In function 'wl3501_rx_interrupt': > drivers/net/wireless/wl3501_cs.c:1103:1: error: the frame size of 2232 bytes is larger than 1536 bytes [-Werror=frame-larger-than=] > > Marking the two callers of insb/outb 'noinline' prevents the compiler > from adding up the stack usage for each of the local variables passed > into those, reducing the maximum stack frame size to 800 bytes with > KASAN again. > > Signed-off-by: Arnd Bergmann Arnd, based on the discussion I'm dropping. Please let me know if I should take this still. -- Kalle Valo