From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753918AbdBHJYE (ORCPT ); Wed, 8 Feb 2017 04:24:04 -0500 Received: from mga06.intel.com ([134.134.136.31]:33956 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753919AbdBHJXv (ORCPT ); Wed, 8 Feb 2017 04:23:51 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,346,1477983600"; d="asc'?scan'208";a="1104573365" From: Felipe Balbi To: "Gustavo A. R. Silva" , gregkh@linuxfoundation.org, bhumirks@gmail.com, mina86@mina86.com Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] drivers: usb: gadget: udc: add missing break in switch In-Reply-To: <20170208072212.GA8209@embeddedgus> References: <20170208072212.GA8209@embeddedgus> Date: Wed, 08 Feb 2017 11:23:27 +0200 Message-ID: <87mvdxxchc.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, "Gustavo A. R. Silva" writes: > Add missing break in switch. > > Addresses-Coverity-ID: 201385 > Signed-off-by: Gustavo A. R. Silva > --- > drivers/usb/gadget/udc/mv_udc_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/gadget/udc/mv_udc_core.c b/drivers/usb/gadget/ud= c/mv_udc_core.c > index 27ebb0d..56b3574 100644 > --- a/drivers/usb/gadget/udc/mv_udc_core.c > +++ b/drivers/usb/gadget/udc/mv_udc_core.c > @@ -489,6 +489,7 @@ static int mv_ep_enable(struct usb_ep *_ep, > break; > case USB_ENDPOINT_XFER_CONTROL: > ios =3D 1; > + break; are you SURE this is supposed to have this break statement? What if we want to initialize mult to 0 *also* for control endpoints? How did you test this? Do you have access to Marvel's documentation for this controller? =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlia448ACgkQzL64meEa mQbYoRAAvfkoAHCp+T1F3QoeM5Wt+Mc53q9mPdiIeCbP4qUL9O8xSDaPGAX9o55p XPhrNYqtVGMN7TiwYv+PmbhvhPE7RyfdjsojBzPmOK50hh54jsSaJXVjHWxyIRoN cwzxgKigBmvo2FTVB8pjLSrzSOVGVbmDaQEgBe+l5aKfLm+yDQPwZIHm+xjYBnNx uTssgUABcdFNYD+TZqx5bN79UjctKJ25nMI0Fl4yYQGUGsZZeWikhWnVs3UZHI79 Dh+JpUu5oj4b32RIkv4eP7kIO51jRsO7ZZQcIw78sRXBr/m14pK1Vfkt60juRotn dDv1pR7lA2BqHb61h3qlTheGfGLCN8BCcULYCweXh6M/BqlCvWgjrrkDtjrzlMHw z6J7UWh0e69ShntQ8h7OCUDxsevT4WJxulEOGw/cyxvKK61g61MnpGzJpbvWZeRe Cv+EK8sRQylQpbXayiHtq2jzcnKcIL+Bak1Te0IjGv8hdpifveH43kSQ+R0P8cQZ dCE+ZCYG/0P63Skc+euS0ubqEmQq7TOGfUyf/ABulkgqE5oRrxoXlehq9CIejIwy Mioxg0NxZ5ZTgtySa9ppj5QL00FaGt0dClOJ4x0m6Qr3A4W9qjAjiCMLpdIcx5G2 orXLaixD93I32CU2L2Ca99HYN0rArIF2YKdj3BUDvbNwdP2xkZg= =SHRk -----END PGP SIGNATURE----- --=-=-=--