From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751952AbcFZE0G (ORCPT ); Sun, 26 Jun 2016 00:26:06 -0400 Received: from anholt.net ([50.246.234.109]:52276 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751911AbcFZE0E (ORCPT ); Sun, 26 Jun 2016 00:26:04 -0400 From: Eric Anholt To: Daniel Lezcano , daniel.lezcano@linaro.org, tglx@linutronix.de Cc: linux-kernel@vger.kernel.org, Stephen Warren , Lee Jones , "moderated list\:BROADCOM BCM2835..." , "moderated list\:BROADCOM BCM2835..." Subject: Re: [PATCH V2 13/63] clocksource/drivers/bcm2835_timer: Convert init function to return error In-Reply-To: <1466112442-31105-14-git-send-email-daniel.lezcano@linaro.org> References: <1466112442-31105-1-git-send-email-daniel.lezcano@linaro.org> <1466112442-31105-14-git-send-email-daniel.lezcano@linaro.org> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Sat, 25 Jun 2016 20:10:18 -0700 Message-ID: <87mvm8myqt.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Daniel Lezcano writes: > The init functions do not return any error. They behave as the following: > > - panic, thus leading to a kernel crash while another timer may work and > make the system boot up correctly > > or > > - print an error and let the caller unaware if the state of the system > > Change that by converting the init functions to return an error conforming > to the CLOCKSOURCE_OF_RET prototype. > > Proper error handling (rollback, errno value) will be changed later case > by case, thus this change just return back an error or success in the init > function. > > Signed-off-by: Daniel Lezcano For the bcm2835 changes here and in 63/63: Acked-by: Eric Anholt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJXb0eaAAoJELXWKTbR/J7oQGAQALnTNXIGEIFDoLFEHb1qO5dS QUBPS3QfJ+gGH4oDTwFoawzrbiWM36fdb2hsVMAGRoSvAtYEHT0crmCjQ2rc7csE AXOMEfYXtfKNxhcekUCO7iNuW1kYwNA8H3Tx8YMvIlGuVzrAaptObk+XppI6weJD CxCcq7RGhfPZa3I/MyDmNAb2Jjl9iC5BtKb1e7strAzUQBIY7QRT+2zDRRVMERjy CVG0UIHXy4wZgpru3QYzWDxhNYvHUKOR48d4mhLiTT/9pqx76zpov/pEFsvl0iir XYfu6be9uxdnchitcPA06lfQuvpIuUqczF3YOLkF8I1MxZzzp/MgGQYvaQ3H+ltQ b/1kbT6Sdyyj3KkIvRSr6NjQoyLM8O3fBYY3Etdl4sr2z4VoETXfqJ2+JBFgVCnI jaUqWju7VLb10147jPbk0p4L6R4/Iho9GE60oeo4ed6RRxR74FTVwZKaERaYvits yg6trcg258VoMdb7krJAzW19GcNTnPVAUviyRYrWDVRQAIfVLRzwDnfhQdK6BIGg m8LxCQqn2jumeCSUZ8xgfo44tzQxYGjpGgGi2RIpK/Ahk4RhXlGTBWy5i+Pjkbpz 5QKzKo6FlUXKifzQDX73az5flr/WPzFD0G6fXuhQdSfxpJM3QEBI38jjF85stxqV FHc9/czOvcAkAK15hiY9 =4CYn -----END PGP SIGNATURE----- --=-=-=--