From: Felipe Balbi <balbi@kernel.org>
To: "Du\, Changbin" <changbin.du@intel.com>
Cc: "gregkh\@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit
Date: Tue, 12 Apr 2016 11:06:42 +0300 [thread overview]
Message-ID: <87mvozl08d.fsf@intel.com> (raw)
In-Reply-To: <0C18FE92A7765D4EB9EE5D38D86A563A05CFEB0F@shsmsx102.ccr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1065 bytes --]
Hi,
"Du, Changbin" <changbin.du@intel.com> writes:
> Hi, Balbi,
>
>> > Hmm, I agree from this point. I will combine this patch with other two
>> patches
>> > (due to their dependency). And I'd like remove the 'dwc->root=NULL' as
>> well,
>>
>> you are creating a dependency that doesn't exist. Please stop that. You
>> should have two separate branches based on v4.6-rc3 (or, if you prefer,
>> one based on my testing/fixes and another based on my testing/next). On
>> one branch you have *only* $subject and you fix *all* the memory
>> leaks. On the other branch you have the other two patches.
>>
>> Ignore the fact that we might have a conflict, that's for git (and
>> maintainers) to handle when they happen.
>>
>> Again, don't create dependencies between fixes for the -rc cycle and
>> changes for the next merge window.
>>
> Thanks for dedicated explanation. I was concern about the conflict.
yeah, no problem ;-)
> Now it is very clear for me to handle such situation.
good :-) glad we could sort it out.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2016-04-12 8:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 9:42 [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit changbin.du
2016-04-11 8:06 ` Felipe Balbi
2016-04-11 11:09 ` Du, Changbin
2016-04-11 11:13 ` Felipe Balbi
2016-04-11 11:38 ` Du, Changbin
2016-04-11 12:09 ` Felipe Balbi
2016-04-12 2:10 ` Du, Changbin
2016-04-12 6:18 ` Felipe Balbi
2016-04-12 6:52 ` Du, Changbin
2016-04-12 8:06 ` Felipe Balbi [this message]
2016-04-12 8:14 ` [PATCH v2] usb: dwc3: fix memory leak of dwc->regset changbin.du
2016-04-12 8:26 ` Felipe Balbi
2016-04-12 8:24 ` [PATCH v3] " changbin.du
2016-04-12 10:09 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvozl08d.fsf@intel.com \
--to=balbi@kernel.org \
--cc=changbin.du@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox