linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Laura Abbott <labbott@redhat.com>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: 0be964be0 "module: Sanitize RCU usage and locking" breaks symbol_put_addr?
Date: Thu, 20 Aug 2015 10:40:55 +0930	[thread overview]
Message-ID: <87mvxmkbmo.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20150819124204.GP10304@worktop.programming.kicks-ass.net>

Peter Zijlstra <peterz@infradead.org> writes:
> On Wed, Aug 19, 2015 at 06:19:43AM +0930, Rusty Russell wrote:
>> Indeed!  That comment is wrong, and your fix is good.
>> 
>> Care to S-O-B on it?
>
> Of course, here goes.

Thanks!  This is an ancient bug (2009) which your extra assertions
caught.  It's unlikely to have ever bitten anyone, but I've CC'd stable
for it anyway:

Fixes: a6e6abd575fc ("module: remove module_text_address()")
Cc: stable@kernel.org

Applied,
Rusty.

      reply	other threads:[~2015-08-20  5:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-17 23:20 0be964be0 "module: Sanitize RCU usage and locking" breaks symbol_put_addr? Laura Abbott
2015-08-18  2:31 ` Peter Zijlstra
2015-08-18 20:49   ` Rusty Russell
2015-08-19 12:42     ` Peter Zijlstra
2015-08-20  1:10       ` Rusty Russell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mvxmkbmo.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=labbott@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).