From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754540AbbCBVju (ORCPT ); Mon, 2 Mar 2015 16:39:50 -0500 Received: from smtp05.smtpout.orange.fr ([80.12.242.127]:52066 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753372AbbCBVjt (ORCPT ); Mon, 2 Mar 2015 16:39:49 -0500 X-ME-Helo: beldin X-ME-Date: Mon, 02 Mar 2015 22:39:47 +0100 X-ME-IP: 109.214.21.72 From: Robert Jarzmik To: Dan Carpenter Cc: Brian Norris , Joe Perches , kernel-janitors@vger.kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] mtd: docg3: drop dead code References: <1425117750-22298-1-git-send-email-computersforpeace@gmail.com> <1425117750-22298-2-git-send-email-computersforpeace@gmail.com> <20150302091050.GC5386@mwanda> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 02 Mar 2015 22:39:42 +0100 In-Reply-To: <20150302091050.GC5386@mwanda> (Dan Carpenter's message of "Mon, 2 Mar 2015 12:10:50 +0300") Message-ID: <87mw3v13kx.fsf@free.fr> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dan Carpenter writes: > On Sat, Feb 28, 2015 at 02:02:24AM -0800, Brian Norris wrote: >> diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c >> index 448ce42f951e..01eddea1f0d9 100644 >> --- a/drivers/mtd/devices/docg3.c >> +++ b/drivers/mtd/devices/docg3.c >> @@ -2079,8 +2079,6 @@ static int __init docg3_probe(struct platform_device *pdev) >> ret = doc_register_sysfs(pdev, cascade); >> if (ret) >> goto err_probe; >> - if (!found) >> - goto notfound; > > Just delete the "found" variable because there are no other uses. Yes, and yes. For both changes (condition killing, found++ eradication and found variable declaration) : Acked-by: Robert Jarzmik Cheers. -- Robert