From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Joe Perches <joe@perches.com>
Cc: Richard Weinberger <richard.weinberger@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
<gmate.amit@gmail.com>, Greg KH <gregkh@linuxfoundation.org>,
Bas Peters <baspeters93@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Pushpendra Singh <pushpendra.singh@smartplayin.com>,
<manuel.schoelling@gmx.de>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Pavel Machek <pavel@ucw.cz>
Subject: Re: checkpatch induced patches...
Date: Thu, 12 Feb 2015 18:44:09 +0200 [thread overview]
Message-ID: <87mw4jjd0m.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1423686025.15343.20.camel@perches.com> (Joe Perches's message of "Wed, 11 Feb 2015 12:20:25 -0800")
Joe Perches <joe@perches.com> writes:
> On Wed, 2015-02-11 at 21:02 +0100, Richard Weinberger wrote:
>> On Wed, Feb 11, 2015 at 7:36 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>> > On Wed, Feb 11, 2015 at 10:00:29AM -0800, Joe Perches wrote:
>> >> I'm half tempted to submit some patch like this to
>> >> make it difficult to use checkpatch on files outside
>> >> of drivers/staging.
>> >>
>> >> o Only allow checkpatch to be used with the -f/--file
>> >> option for drivers/staging/
>> >> o Add an undocumented --force command line option
>> >
>> > Sure. We could try that. I once sent a patch to make -f generate a
>> > warning about not wasting people's time, but this is also ok.
>> >
>> >> o Make --strict the default for drivers/staging
>> >
>> > Ack.
>>
>> FYI: We had already a heated debate on that topic.
>> https://lkml.org/lkml/2014/7/17/415
>
> Yeah, I remember.
>
> It's always a pleasure to chat with Borislav.
>
> This is basically a patch that implements my suggestion
> in that thread.
>
> https://lkml.org/lkml/2014/7/17/427
>
> I wonder if the undocumented --force option is acceptable
> to Pavel and Kalle.
I don't mind if I have to add --force to my scripts as long as
checkpatch works similarly as before.
--
Kalle Valo
next prev parent reply other threads:[~2015-02-12 16:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 13:02 [PATCH 1/6] staging: rt8188eu: hal: removed space before ',' Pushpendra Singh
2015-02-10 13:02 ` [PATCH 2/6] staging: rtl8188eu: hal: removed code indent error Pushpendra Singh
2015-02-10 14:13 ` Sudip Mukherjee
2015-02-10 14:27 ` Bas Peters
2015-02-10 14:48 ` Sudip Mukherjee
2015-02-11 8:33 ` Dan Carpenter
2015-02-11 9:40 ` Joe Perches
2015-02-11 10:51 ` Dan Carpenter
2015-02-11 18:00 ` checkpatch induced patches Joe Perches
2015-02-11 18:36 ` Dan Carpenter
2015-02-11 20:02 ` Richard Weinberger
2015-02-11 20:20 ` Joe Perches
2015-02-11 20:24 ` Pavel Machek
2015-02-11 20:43 ` Joe Perches
2015-02-11 22:43 ` Dan Carpenter
2015-02-11 22:46 ` Richard Weinberger
2015-02-11 23:01 ` Joe Perches
2015-02-12 8:03 ` Sudip Mukherjee
2015-02-12 16:44 ` Kalle Valo [this message]
2015-02-10 22:25 ` [PATCH 2/6] staging: rtl8188eu: hal: removed code indent error Greg KH
2015-02-10 13:02 ` [PATCH 3/6] staging: rtl8188eu: hal: removed unnecessary braces Pushpendra Singh
2015-02-10 13:02 ` [PATCH 4/6] staging: rtl8188eu: hal: added blank line after declarations Pushpendra Singh
2015-02-10 13:02 ` [PATCH 5/6] staging: rtl8188eu: hal: removed spaces at start of line Pushpendra Singh
2015-02-10 13:02 ` [PATCH 6/6] staging: rtl8188eu: hal: removed unnecessary parentheses Pushpendra Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mw4jjd0m.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=akpm@linux-foundation.org \
--cc=baspeters93@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gmate.amit@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manuel.schoelling@gmx.de \
--cc=pavel@ucw.cz \
--cc=pushpendra.singh@smartplayin.com \
--cc=richard.weinberger@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox