From: Rusty Russell <rusty@rustcorp.com.au>
To: Kees Cook <keescook@chromium.org>
Cc: Oded Gabbay <oded.gabbay@amd.com>,
Andi Kleen <ak@linux.intel.com>,
Alex Deucher <alexdeucher@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Dana Elifaz <Dana.Elifaz@amd.com>,
LKML <linux-kernel@vger.kernel.org>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
Alexander Deucher <Alexander.Deucher@amd.com>,
LKP ML <lkp@01.org>
Subject: Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel
Date: Wed, 07 Jan 2015 09:28:31 +1030 [thread overview]
Message-ID: <87mw5v4iug.fsf@rustcorp.com.au> (raw)
In-Reply-To: <CAGXu5jJ71tM99uaRoq74AkcB5KhxsfBS3NyDuJ2rJncKmfCWwg@mail.gmail.com>
Kees Cook <keescook@chromium.org> writes:
> On Sun, Jan 4, 2015 at 8:28 PM, Rusty Russell <rusty@rustcorp.com.au> wrote:
>> Kees, as far as I can tell you need another 0-terminated vmlinux.relocs
>> section for weak symbols. These should not be relocated if already 0.
>
> A few questions:
>
> Why doesn't this break on 32-bit without kASLR? 32-bit does relocation
> by default, even without CONFIG_RANDOMIZE_BASE.
Well, the offset was 0 until I removed CONFIG_HIBERNATE.
> Are there any symbols that are NULL that aren't weak? I'd expect all
> strong symbols to have non-zero offsets, but I must be
> misunderstanding something here.
I don't think there would be. Anyway, you might be able to filter them
out in x86/tools/relocs itself.
Cheers,
Rusty.
next prev parent reply other threads:[~2015-01-07 0:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-22 11:11 [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel Oded Gabbay
2014-12-22 16:58 ` Alex Deucher
2014-12-22 18:49 ` [LKP] " Andi Kleen
2014-12-22 19:00 ` Andi Kleen
2014-12-22 19:18 ` Oded Gabbay
2014-12-23 23:01 ` Rusty Russell
2014-12-24 9:22 ` Oded Gabbay
2015-01-05 4:28 ` Rusty Russell
2015-01-06 20:14 ` Kees Cook
2015-01-06 22:58 ` Rusty Russell [this message]
2015-01-11 11:57 ` Oded Gabbay
2015-01-13 17:15 ` Kees Cook
2015-01-16 0:27 ` Kees Cook
2015-01-16 11:27 ` Oded Gabbay
2015-01-23 4:10 ` Rusty Russell
2014-12-25 12:31 ` Christian König
2014-12-28 9:05 ` Oded Gabbay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mw5v4iug.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=Alexander.Deucher@amd.com \
--cc=Dana.Elifaz@amd.com \
--cc=ak@linux.intel.com \
--cc=alexdeucher@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=oded.gabbay@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).