From: Rusty Russell <rusty@rustcorp.com.au>
To: Arjun Sreedharan <arjun024@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jingoo Han <jg1.han@samsung.com>,
linux-kernel@vger.kernel.org
Cc: David Woodhouse <David.Woodhouse@intel.com>
Subject: Re: [PATCH] params: fix potential memory leak in add_sysfs_param()
Date: Thu, 21 Aug 2014 06:19:03 +0930 [thread overview]
Message-ID: <87mwayj39c.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1408564816-1778-1-git-send-email-arjun024@gmail.com>
Arjun Sreedharan <arjun024@gmail.com> writes:
> Do not leak memory when attrs is non NULL and
> krealloc() fails. Without temporary variable,
> reference to it is lost.
>
> Signed-off-by: Arjun Sreedharan <arjun024@gmail.com>
...
> }
> - /* Despite looking like the typical realloc() bug, this is safe.
> - * We *want* the old 'attrs' to be freed either way, and we'll store
> - * the new one in the success case. */
> - attrs = krealloc(attrs, sizeof(new->grp.attrs[0])*(num+2), GFP_KERNEL);
> - if (!attrs) {
> +
> + new_attrs = krealloc(attrs, sizeof(new->grp.attrs[0])*(num+2), GFP_KERNEL);
> + if (!new_attrs) {
I think that comment you deleted is pretty clear. Is it wrong?
Cheers,
Rusty.
next prev parent reply other threads:[~2014-08-20 20:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 20:00 [PATCH] params: fix potential memory leak in add_sysfs_param() Arjun Sreedharan
2014-08-20 20:49 ` Rusty Russell [this message]
2014-08-20 21:08 ` Arjun Sreedharan
2014-08-20 22:05 ` Rusty Russell
2014-08-20 22:17 ` Woodhouse, David
2014-08-20 23:10 ` David Woodhouse
2014-08-21 6:50 ` Arjun Sreedharan
2014-08-20 21:36 ` Woodhouse, David
-- strict thread matches above, loose matches on Subject: below --
2013-03-14 13:36 [PATCH] params: Fix " David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwayj39c.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=arjun024@gmail.com \
--cc=jg1.han@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox