public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Michael Hudson-Doyle <michael.hudson@linaro.org>,
	linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>,
	Will Deacon <will.deacon@arm.com>,
	Jean Pihet <jean.pihet@linaro.org>,
	Namhyung Kim <namhyung.kim@lge.com>
Subject: Re: [PATCH] perf tools: Remove cast of non-varadic function to varadic
Date: Fri, 01 Nov 2013 16:51:17 +0900	[thread overview]
Message-ID: <87mwlo4l1m.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <20131031200950.GA5949@infradead.org> (Arnaldo Carvalho de Melo's message of "Thu, 31 Oct 2013 18:09:50 -0200")

Hi Arnaldo and Michael,

On Thu, 31 Oct 2013 18:09:50 -0200, Arnaldo Carvalho de Melo wrote:
> Em Thu, Oct 31, 2013 at 12:50:25PM -0700, Michael Hudson-Doyle escreveu:
>> 4fb71074a570 (perf ui/hist: Consolidate hpp helpers) introduced a cast of
>> percent_color_snprintf to a function pointer type with varargs.  Change
>> percent_color_snprintf to be varadic and remove the cast.
>> 
>> The symptom of this was all percentages being reported as 0.00% in perf
>> report --stdio output on armhf.
>
> git bisect + visual inspection, right? Anyway, good catch, interesting
> it caused problems on just one arch, or have you tested this in other
> arches?
>
> Namhyung?

Yes, it'll affect the way of passing parameter on some arch's -  I only
tested it on x86_64.  So,

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung

      parent reply	other threads:[~2013-11-01  7:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-31 19:50 [PATCH] perf tools: Remove cast of non-varadic function to varadic Michael Hudson-Doyle
2013-10-31 20:06 ` Will Deacon
2013-10-31 20:09 ` Arnaldo Carvalho de Melo
2013-10-31 21:19   ` Michael Hudson-Doyle
2013-11-01  7:51   ` Namhyung Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mwlo4l1m.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=acme@ghostprotocols.net \
    --cc=jean.pihet@linaro.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.hudson@linaro.org \
    --cc=namhyung.kim@lge.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox