From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758185Ab2DIXfh (ORCPT ); Mon, 9 Apr 2012 19:35:37 -0400 Received: from na3sys009aog132.obsmtp.com ([74.125.149.250]:43519 "EHLO psmtp.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753491Ab2DIXff (ORCPT ); Mon, 9 Apr 2012 19:35:35 -0400 From: Kevin Hilman To: Santosh Shilimkar Cc: Colin Cross , Len Brown , Kay Sievers , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Amit Kucheria , linux-pm@lists.linux-foundation.org, Arjan van de Ven , Rob Lee , linux-arm-kernel@lists.infradead.org Subject: Re: [linux-pm] [PATCHv2 0/5] coupled cpuidle state support Organization: Texas Instruments, Inc. References: <1331749794-8056-1-git-send-email-ccross@android.com> <4F75ACCA.4090009@ti.com> <4F828BAB.5010302@ti.com> Date: Mon, 09 Apr 2012 16:35:40 -0700 In-Reply-To: <4F828BAB.5010302@ti.com> (Santosh Shilimkar's message of "Mon, 09 Apr 2012 12:41:39 +0530") Message-ID: <87mx6k7a2b.fsf@ti.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Santosh Shilimkar writes: > On Friday 30 March 2012 06:23 PM, Santosh Shilimkar wrote: >> Colin, >> >> On Friday 16 March 2012 05:07 AM, Colin Cross wrote: >>> On Wed, Mar 14, 2012 at 11:29 AM, Colin Cross wrote: >> >> [...] >> >>>> >>>> v2: >>>> * removed the coupled lock, replacing it with atomic counters >>>> * added a check for outstanding pokes before beginning the >>>> final transition to avoid extra wakeups >>>> * made the cpuidle_coupled struct completely private >>>> * fixed kerneldoc comment formatting >>>> * added a patch with a helper function for resynchronizing >>>> cpus after aborting idle >>>> * added a patch (not for merging) to add trace events for >>>> verification and performance testing >>> >>> I forgot to mention, this patch series is on v3.3-rc7, and will >>> conflict with the cpuidle timekeeping patches. If those go in first >>> (which is likely), I will rework this series on top of it. I left it >>> on v3.3-rc7 now to make testing easier. >> >> I have re-based your series against Len Browns >> next branch [1] which has time keeping and other cpuidle patches. >> Have also folded the CPU hotplug fix which I posted in the >> original coupled idle patch. >> > As you know, we have been playing around this series for OMAP > for last few weeks. This version series seems to work as intended > and found it pretty stable in my testing. Apart from the cpu > hotplug fix and the trace event comment, series looks fine > to me. > > FWIW, > Reviewed-by: Santosh Shilimkar > Tested-by: Santosh Shilimkar Also Reviewed-by: Kevin Hilman Tested-by: Kevin Hilman as I've been working with Santosh on getting this stabilized on OMAP and we are very keen to see this functionality merged. Thanks, Kevin