From: Eric Anholt <eric@anholt.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [git pull] drm-intel fixes since 2.6.35-rc4
Date: Mon, 26 Jul 2010 13:53:09 -0700 [thread overview]
Message-ID: <87mxteezii.fsf@pollan.anholt.net> (raw)
In-Reply-To: <AANLkTi=T90D3KNpsVCkyLgEQK4XZ2D6YA6U7pjFNdCUK@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1219 bytes --]
On Mon, 26 Jul 2010 13:19:14 -0700, Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Mon, Jul 26, 2010 at 12:13 PM, Eric Anholt <eric@anholt.net> wrote:
> > The following changes since commit 815c4163b6c8ebf8152f42b0a5fd015cfdcedc78:
> >
> > Linux 2.6.35-rc4 (2010-07-04 20:22:50 -0700)
> >
> > are available in the git repository at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/anholt/drm-intel for-linus
>
> Hmm. This seems to introduce a new warning:
>
> drivers/gpu/drm/i915/intel_dp.c:744: warning:
> ‘ironlake_edp_panel_off’ defined but not used
>
> when I pulled it.
>
> And the warning appears to be due to a real bug: instead of calling
> ironlake_edp_panel_off(), the code calls ironlake_edp_backlight_off()
> twice. I assume that the _intention_ was to call both the backlight
> and panel "off" routines, rather than making doubly sure that just the
> backlight is off by turning it off twice.
>
> Tssk, tssk. Sadly, I noticed this too late, so now it's pulled and pushed out.
And I managed to botch that while hand-resolving the patch that was sent
against the wrong tree instead of bouncing it. I'm going to be more
strict on that in the future.
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2010-07-26 20:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 19:13 [git pull] drm-intel fixes since 2.6.35-rc4 Eric Anholt
2010-07-26 20:19 ` Linus Torvalds
2010-07-26 20:33 ` Jesse Barnes
2010-07-26 20:53 ` Jesse Barnes
2010-07-26 20:53 ` Eric Anholt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mxteezii.fsf@pollan.anholt.net \
--to=eric@anholt.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox