Re: [PATCH] failslab: add abitily to filter slab caches

[Dmitry Monakhov <dmonakhov@openvz.org>]

Akinobu Mita <akinobu.mita@gmail.com> writes:

> 2010/2/23 Dmitry Monakhov <dmonakhov@openvz.org>:
>> Example:
>> echo 1 > /sys/kernel/slab/skbuff_head_cache/failslab
>> echo 1 > /sys/kernel/debug/failslab/cache-filter
>
> Looks good.
>
> .Should we also support clearing the flag by
> "echo 0 > /sys/kernel/slab/skbuff_head_cache/failslab" ?
But it already does this, any output except "1" treated as '0'
I've snipped this from trace option.
>
>> +static ssize_t failslab_store(struct kmem_cache *s, const char *buf,
>> +                                                       size_t length)
>> +{
>> +       s->flags &= ~SLAB_FAILSLAB;
>> +       if (buf[0] == '1')
>> +               s->flags |= SLAB_FAILSLAB;
>> +       return length;
>> +}
>> +SLAB_ATTR(failslab);