From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758180AbZKDVCR (ORCPT ); Wed, 4 Nov 2009 16:02:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758162AbZKDVCQ (ORCPT ); Wed, 4 Nov 2009 16:02:16 -0500 Received: from one.firstfloor.org ([213.235.205.2]:34970 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758155AbZKDVCQ (ORCPT ); Wed, 4 Nov 2009 16:02:16 -0500 To: Christoph Lameter Cc: KAMEZAWA Hiroyuki , "hugh.dickins@tiscali.co.uk" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, Tejun Heo Subject: Re: [MM] Remove rss batching from copy_page_range() From: Andi Kleen References: Date: Wed, 04 Nov 2009 22:02:20 +0100 In-Reply-To: (Christoph Lameter's message of "Wed, 4 Nov 2009 14:17:24 -0500 (EST)") Message-ID: <87my3280mb.fsf@basil.nowhere.org> User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/22.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christoph Lameter writes: > From: Christoph Lameter > Subject: Remove rss batching from copy_page_range() > > With per cpu counters in mm there is no need for batching > mm counter updates anymore. Update counters directly while > copying pages. Hmm, but with all the inlining with some luck the local counters will be in registers. That will never be the case with the per cpu counters. So I'm not sure it's really an improvement? -Andi -- ak@linux.intel.com -- Speaking for myself only.