From: Andi Kleen <andi@firstfloor.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Suresh Siddha <suresh.b.siddha@intel.com>,
Tejun Heo <tj@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: use near online node instead of round bin for numa
Date: Mon, 05 Oct 2009 16:44:10 +0200 [thread overview]
Message-ID: <87my45yk79.fsf@basil.nowhere.org> (raw)
In-Reply-To: <4AC7974C.20304@kernel.org> (Yinghai Lu's message of "Sat, 03 Oct 2009 11:26:20 -0700")
Yinghai Lu <yinghai@kernel.org> writes:
> cpu to node mapping is set in following sequence:
> 1. numa_init_array: set up roundbin from cpu to online node
> 2. init_cpu_to_node: set that according to apicid_to_node[] according to srat
> only handle that node is online, and leave other cpu on node
> without ram (aka not online) to still round-bin
> 3. later srat_detect_node for intel/amd, will use first_online node or near by
> node.
>
> problem is that setup_per_cpu_areas() is called between 2 and 3. the per_cpu
> for cpu on node with ram is on different node. and could put that on node with
> two hops away.
>
> so try add find_near_online_node() and call int init_cpu_to_node()
This fallback case should not really happen anyways, unless the BIOS is buggy
(in this case it might better to completely reject the SRAT because
more might be wrong).
Do you have a system where this is needed?
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-10-05 14:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-03 18:26 [PATCH] x86: use near online node instead of round bin for numa Yinghai Lu
2009-10-05 14:44 ` Andi Kleen [this message]
2009-10-05 18:09 ` Yinghai Lu
2009-10-05 18:35 ` Andi Kleen
2009-10-05 18:40 ` Yinghai Lu
2009-10-05 18:50 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87my45yk79.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).