From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1758659AbZEKMSj@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758659AbZEKMSj (ORCPT <rfc822;w@1wt.eu>);
	Mon, 11 May 2009 08:18:39 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758160AbZEKMRc
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 11 May 2009 08:17:32 -0400
Received: from mail-fx0-f158.google.com ([209.85.220.158]:39500 "EHLO
	mail-fx0-f158.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1758126AbZEKMRa (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 11 May 2009 08:17:30 -0400
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:message-id:from:to:cc:subject:in-reply-to:references
         :user-agent:mime-version:content-type;
        b=SaZcIM89wY6m4LG+e/gIsrpe6xDxcFY7jMoUtbdbN+aiSfXLKbfEVE22/L+FgEVaIA
         N1HQqXdjs/S16Nhgb0bp3Q/cLW4ZbyKsvNreWfeonEoXvtlg5hYsA0k57odQRzK92hEP
         MlhzjJ/5WNCQ+2yU2nvoG4xXzawxMuSBCgA/8=
Date: Mon, 11 May 2009 14:17:27 +0200
Message-ID: <87my9jj0ko.wl%vmayatsk@redhat.com>
From: Vitaly Mayatskikh <v.mayatskih@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Vitaly Mayatskikh <v.mayatskih@gmail.com>,
       Andrew Morton <akpm@linux-foundation.org>,
       Oleg Nesterov <oleg@redhat.com>, Ingo Molnar <mingo@elte.hu>,
       Roland McGrath <roland@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] Split wait_noreap_copyout()
In-Reply-To: <20090511120418.GA3859@infradead.org>
References: <1242036759-4025-1-git-send-email-v.mayatskih@gmail.com>
	<1242036759-4025-2-git-send-email-v.mayatskih@gmail.com>
	<20090511120418.GA3859@infradead.org>
User-Agent: Wanderlust/2.15.6 (Almost Unreal) Emacs/22.3 Mule/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Mon, 11 May 2009 08:04:18 -0400, Christoph Hellwig wrote:

> wouldn't this better be written as:
> 
> static int wait_copyout(struct wait_opts *wo, struct task_struct *p,
> 			pid_t pid, uid_t uid, int why, int status, int signal)
> {
> 	struct siginfo __user *infop = wo->wo_info;
> 
> 	if (wo->wo_rusage) {
> 		int retval = getrusage(p, RUSAGE_BOTH, wo->wo_rusage);
> 		if (retval)
> 			return retval;
> 	}
> 
> 	if (!infop)
> 		return 0;
> 
> 	if (put_user(signal, &infop->si_signo) ||
> 	    put_user(0, &infop->si_errno) ||
> 	    put_user((short)why, &infop->si_code) ||
> 	    put_user(pid, &infop->si_pid) ||
> 	    put_user(uid, &infop->si_uid) ||
> 	    put_user(status, &infop->si_status))
> 		return -EFAULT;
> 	return 0;
> }

Yes. But I'm planning to get rid of put_user() in next patches.

-- 
wbr, Vitaly