From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756127AbYIJWk4 (ORCPT ); Wed, 10 Sep 2008 18:40:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753730AbYIJWkt (ORCPT ); Wed, 10 Sep 2008 18:40:49 -0400 Received: from nebensachen.de ([195.34.83.29]:38914 "EHLO mail.nebensachen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753026AbYIJWks (ORCPT ); Wed, 10 Sep 2008 18:40:48 -0400 X-Hashcash: 1:20:080910:steven@uplinklabs.net::VqlNt2AdhTXLXaPg:00000000000000000000000000000000000000004rdm X-Hashcash: 1:20:080910:bzolnier@gmail.com::gid7i5E66/+jw1o/:00000000000000000000000000000000000000000000trC X-Hashcash: 1:20:080910:linux-kernel@vger.kernel.org::SpxhlM2qbnAR7lV+:0000000000000000000000000000000001Bxe X-Hashcash: 1:20:080910:mingo@elte.hu::+NtKmzsldEw3Ssmz:00001D+9 From: Elias Oltmanns To: "Steven Noonan" Cc: "Bartlomiej Zolnierkiewicz" , linux-kernel@vger.kernel.org, mingo@elte.hu Subject: Re: [PATCH] drivers/ide/ide-probe.c: uninitialized variable 'rc' References: <1220994461-15962-1-git-send-email-steven@uplinklabs.net> <200809102309.34159.bzolnier@gmail.com> Date: Thu, 11 Sep 2008 00:40:23 +0200 In-Reply-To: (Steven Noonan's message of "Wed, 10 Sep 2008 14:19:56 -0700") Message-ID: <87myifmxpk.fsf@denkblock.local> User-Agent: Gnus/5.110007 (No Gnus v0.7) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Steven Noonan" wrote: > On Wed, Sep 10, 2008 at 2:09 PM, Bartlomiej Zolnierkiewicz > wrote: >> > >> I recall seeing identical patch before: >> >> http://article.gmane.org/gmane.linux.ide/33107 >> >> Does the existing code really results in gcc warning? >> >> > > Yes, because GCC thinks it's possible that the for loop has zero > iterations (and hence, 'rc' is never touched). What about changing the declaration to int i, uninitialized_var(rc); then? Regards, Elias