From: Olaf Dietsche <olaf.dietsche#list.linux-kernel@t-online.de>
To: Werner Almesberger <wa@almesberger.net>
Cc: Andrew Morton <akpm@digeo.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5.47: strdup()
Date: Mon, 18 Nov 2002 03:43:43 +0100 [thread overview]
Message-ID: <87n0o7mwbk.fsf@goat.bogus.local> (raw)
In-Reply-To: 20021117203213.K1407@almesberger.net
Werner Almesberger <wa@almesberger.net> writes:
> Olaf Dietsche wrote:
>> +static inline char *strdup(const char *s) { return kstrdup(s, GFP_KERNEL); }
>
> Why hide what's really going on ? Better change the callers to use
> kstrdup.
Convenience and laziness. And I haven't seen any other strdup() use,
which uses different allocation flags. But it's there for everybody to
use, if they wish.
Regards, Olaf.
next prev parent reply other threads:[~2002-11-18 2:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-16 6:21 [PATCH] 2.5.47: strdup() Olaf Dietsche
2002-11-16 6:25 ` Jeff Garzik
2002-11-16 6:31 ` Andrew Morton
2002-11-16 15:42 ` Olaf Dietsche
2002-11-17 23:32 ` Werner Almesberger
2002-11-18 2:43 ` Olaf Dietsche [this message]
2002-11-16 6:41 ` William Lee Irwin III
2002-11-17 0:08 ` Chris Wedgwood
2002-11-17 1:37 ` Olaf Dietsche
2002-11-17 4:40 ` Chris Wedgwood
-- strict thread matches above, loose matches on Subject: below --
2002-11-16 8:48 Peter Kjellerstedt
2002-11-16 15:53 ` Olaf Dietsche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87n0o7mwbk.fsf@goat.bogus.local \
--to=olaf.dietsche#list.linux-kernel@t-online.de \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wa@almesberger.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox