From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: "Rob Herring (Arm)" <robh@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>
Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: watchdog: Convert marvell,orion-wdt to DT schema
Date: Tue, 14 Oct 2025 11:45:39 +0200 [thread overview]
Message-ID: <87o6q9g6kc.fsf@BLaptop.bootlin.com> (raw)
In-Reply-To: <20251013213146.695195-1-robh@kernel.org>
Hello Rob,
Thank you for your work. I have one question:
> + reg:
> + minItems: 2
Should we also include this constraint here?
maxItems: 3
This would further restrict the binding.
Gregory
> + items:
> + - description: Timer control register address.
> + - description: RSTOUT enable register address.
> + - description: Shared mask/unmask RSTOUT register address.
> +
[...]
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - marvell,armada-375-wdt
> + - marvell,armada-380-wdt
> + then:
> + properties:
> + reg:
> + minItems: 3
> + else:
> + properties:
> + reg:
> + maxItems: 2
> +
--
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2025-10-14 9:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 21:31 [PATCH] dt-bindings: watchdog: Convert marvell,orion-wdt to DT schema Rob Herring (Arm)
2025-10-14 9:45 ` Gregory CLEMENT [this message]
2025-10-14 11:21 ` Rob Herring
2025-10-14 12:39 ` Gregory CLEMENT
2025-10-14 14:56 ` Guenter Roeck
2025-10-14 20:22 ` Sander Vanheule
2025-10-14 22:33 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o6q9g6kc.fsf@BLaptop.bootlin.com \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox