From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D52871BC4E; Sun, 21 Sep 2025 15:32:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758468737; cv=none; b=A0WzQFwLsPK93hz6d6ojwX5k4LTMCobQwwejDmfvsyjxBMc1G/a2pO8QmNF2VlTac78WsptAsZ+xPvoAUWqqnuk2ljGXAj9bKb+sdwyXK+Dbd8KTUcZ38G4PeVYkrHcM1WFApmGj4CwwQzyC8amCqpSwqU+o6eKgk7XOjr5vK44= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758468737; c=relaxed/simple; bh=Fm+N0kWNQ92Y1DMiMDIqpCjseiY46IKkj1Fc+PKJUH0=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=qRMl6yPO8chfjAsub4HG7k9doyQPJhSKiSS/rfZx6ZDOmgUQYp4CFYLH48BuzK9+g+raL1+59WCa3vd+RSttVAskfmjgT6//WAVP+SAiySNOQWKOWarJLAtmiJEapt8UclJJuy4dcaOWa2Oe8UR8tqxG8Z+6rTI8QvPI8BoBlQQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kHGW8kbz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kHGW8kbz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4FF8FC4CEE7; Sun, 21 Sep 2025 15:32:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758468737; bh=Fm+N0kWNQ92Y1DMiMDIqpCjseiY46IKkj1Fc+PKJUH0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kHGW8kbzFPLcYJpbavA3z7NgZMyIajbTdJzzZaCDAEd4LiSMiTIzfLe6emGprt6Mp zHnJ8FML6wYevYWXEhzuRyAHGwpPeJfTA550fFx/Xf8YUeA18iv4HGFCXhkh0HLc+3 Cf8Jq7aYGl8DBoz57776P/k0oAOp6hcwwHiNDi8lu5ZuyjVS/QEfQ8S+7wSN9+48ZQ F8CgZUg5oaO/Wdit6JyOD5ZN36ol/au7I7FxvgdjPb6Vov2ybmoqT1Et2F+vzEt4F6 koKFPY9KfiZ/D4WzMq3ehXkGAJXxCQVyo6ZMgFgTMzAISVDBV/4RBUvF0s2HbDzgpQ LUZ2EzVd2W21Q== Received: from sofa.misterjones.org ([185.219.108.64] helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1v0M2w-00000008BVR-3w1R; Sun, 21 Sep 2025 15:32:15 +0000 Date: Sun, 21 Sep 2025 16:32:14 +0100 Message-ID: <87o6r3yg75.wl-maz@kernel.org> From: Marc Zyngier To: Jonathan Cameron Cc: , , , Thomas Gleixner , "Mark\ Rutland" , Will Deacon , "Rafael J.\ Wysocki" , Rob Herring , "Saravana\ Kannan" , Greg Kroah-Hartman , Sven Peter , Janne Grunau , Suzuki K Poulose , James Clark Subject: Re: [PATCH v2 11/25] genirq: Kill handle_percpu_devid_fasteoi_nmi() In-Reply-To: <20250916163838.00003791@huawei.com> References: <20250915085702.519996-1-maz@kernel.org> <20250915085702.519996-12-maz@kernel.org> <20250916163838.00003791@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: jonathan.cameron@huawei.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, tglx@linutronix.de, mark.rutland@arm.com, will@kernel.org, rafael@kernel.org, robh@kernel.org, saravanak@google.com, gregkh@linuxfoundation.org, sven@kernel.org, j@jannau.net, suzuki.poulose@arm.com, james.clark@linaro.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 16 Sep 2025 16:38:38 +0100, Jonathan Cameron wrote: > > On Mon, 15 Sep 2025 09:56:48 +0100 > Marc Zyngier wrote: > > > There is no in-tree user of this flow handler anymore, so simply > > remove it. > > > > Suggested-by: Will Deacon > > Signed-off-by: Marc Zyngier > > --- > > > diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c > > index 0d0276378c707..869068ec6ac91 100644 > > --- a/kernel/irq/chip.c > > +++ b/kernel/irq/chip.c > > @@ -892,7 +892,8 @@ void handle_percpu_irq(struct irq_desc *desc) > > * > > * action->percpu_dev_id is a pointer to percpu variables which > > * contain the real device id for the cpu on which this handler is > > - * called > > + * called. This is also used for per-CPU NMIs, so special care is > > + * required. > > Probably belongs in previous patch as not really related to removing > the unused code, but meh. Actually, I think I'll simply drop this comment. It really doesn't bring much to the table. Thanks, M. -- Jazz isn't dead. It just smells funny.