From: Thomas Gleixner <tglx@linutronix.de>
To: Wake Liu <wakel@google.com>, John Stultz <jstultz@google.com>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
Frederic Weisbecker <frederic@kernel.org>,
Shuah Khan <shuah@kernel.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
wakel@google.com
Subject: Re: [PATCH] selftests/timers: Skip some posix_timers tests on kernels < 6.13
Date: Sun, 21 Sep 2025 09:59:27 +0200 [thread overview]
Message-ID: <87o6r46xsw.ffs@tglx> (raw)
In-Reply-To: <20250807085042.1690931-1-wakel@google.com>
On Thu, Aug 07 2025 at 16:50, Wake Liu wrote:
> Several tests in the posix_timers selftest fail on kernels older
> than 6.13. These tests check for timer behavior related to SIG_IGN,
> which was refactored in the 6.13 kernel cycle, notably by
> commit caf77435dd8a ("signal: Handle ignored signals in
> do_sigaction(action != SIG_IGN)").
>
> To ensure the selftests pass on older, stable kernels, gate the
> affected tests with a ksft_min_kernel_version(6, 13) check.
What's the point of emitting 9 times the same skip message?
There is no value at all and this can nicely be solved in main() by
checking the kernel version once, registering either 10 or 19 tests and
not invoking the tests which depend on 6.13+ in the first place, No?
Thanks,
tglx
next prev parent reply other threads:[~2025-09-21 7:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 8:50 [PATCH] selftests/timers: Skip some posix_timers tests on kernels < 6.13 Wake Liu
2025-09-21 7:59 ` Thomas Gleixner [this message]
2025-11-03 11:45 ` [PATCH v2] selftests/timers: Clean up kernel version check in posix_timers Wake Liu
2025-11-14 19:39 ` [tip: timers/core] " tip-bot2 for Wake Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o6r46xsw.ffs@tglx \
--to=tglx@linutronix.de \
--cc=anna-maria@linutronix.de \
--cc=frederic@kernel.org \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=shuah@kernel.org \
--cc=wakel@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox