Re: [PATCH] wifi: ath11k: add support for QCA6698AQ

[Kalle Valo <kvalo@kernel.org>]

Jeff Johnson <quic_jjohnson@quicinc.com> writes:

> On 10/30/2024 5:05 PM, Miaoqing Pan wrote:
>> QCA6698AQ IP core is the same as WCN6855 hw2.1, they share the same
>> PCI device ID, the same major and minor version numbers, the same
>> register address, and same HAL descriptors, etc. The most significant
>> difference is that QCA6698AQ has different RF, IPA, thermal, etc.
>> 
>> Follow the approach done in commit 5dc9d1a55e95 ("wifi: ath11k: add
>> support for QCA2066"), enumerate the subversion number to identify the
>> specific card.
>> 
>> Tested-on: QCA6698AQ hw2.1 PCI WLAN.HSP.1.1-04479-QCAHSPSWPL_V1_V2_SILICONZ_IOE-1
>> 
>> Signed-off-by: Miaoqing Pan <quic_miaoqing@quicinc.com>
>
> Am I correct that this satisfies at least a subset of the devices you were
> trying to support with the following?
> https://lore.kernel.org/all/20241024002514.92290-1-quic_miaoqing@quicinc.com/
>
> If so, can you reply to that thread, pointing to this new patch, and elaborate
> on what is now supported and what still requires ath11k to support
> board-specific firmware overrides?

That question is still open but otherwise this patch looks good to me.
But I'll give an Acked-by only after I understand what's that "NFA765
m.2 card for IoT platforms" mentioned in the other thread is.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches