From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34C4723A6; Tue, 10 Sep 2024 08:25:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725956735; cv=none; b=ZzomqiDQ6vR6UW8OlhU0gsemvuz7Mechwj4Pjyi6D8emTx49yClUAPtN1iFcg0zdVp6E1dOS+QWhigULTh6whGAkQ0ZHeDAJTQdAiyjEOfgK5sqiJfVnZPYMFV9DtGUogdjuCwrHVe/4W5o43cGdZ/DPlEyxnj7nLBkj73ga0mM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725956735; c=relaxed/simple; bh=vvHLiG13qBsdMZuOzc1QI+0M9fdl03EqHawj49sj3gI=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=hmszk7wfwdqefd4EpQC32Tbhx4H6XDnYZuuRBDAHrtwJK+PCQ9qgKMecwVggU/hBCoPIHkwsua/R9YLz9+synYETOZCwuh0WRHXE1dgjQ7haCBD1ZFqXhMOwRMUR8OS2FZRM8YxWd9+49+GKZIlnJGnjrAgW+kwRiCk01DFnGWM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=I8SqZ3HY; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=fg2MBvVC; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=I8SqZ3HY; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=fg2MBvVC; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="I8SqZ3HY"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="fg2MBvVC"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="I8SqZ3HY"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="fg2MBvVC" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2C42121A44; Tue, 10 Sep 2024 08:25:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1725956732; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vcOxYk2DbdWCOhuu8P7USBEBMDbRMgApBCvTiBhhjlE=; b=I8SqZ3HY+O+Z6gjdutN5j/IpA1IlXehlImJquxTmMfc7bget30yQ6VrDJoL/zurXN1fJ5b bIKee8XqF6RWf0+R+PpqWTM6hzZNpNR2GPyWQW0xSQWx5e1iGM0vaMTpmT0ydpjvkyZJMN JYAkUpVHQ7H7e66aYg62Ia/UiyZ1jjo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1725956732; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vcOxYk2DbdWCOhuu8P7USBEBMDbRMgApBCvTiBhhjlE=; b=fg2MBvVCD6TlZoA1X0Ws9dhzipIvtHksmbbukwbvKtqNd4lOG+8j610FrxSBp1mhHbhZ+P GnijqSrJCDAfbeDw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=I8SqZ3HY; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=fg2MBvVC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1725956732; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vcOxYk2DbdWCOhuu8P7USBEBMDbRMgApBCvTiBhhjlE=; b=I8SqZ3HY+O+Z6gjdutN5j/IpA1IlXehlImJquxTmMfc7bget30yQ6VrDJoL/zurXN1fJ5b bIKee8XqF6RWf0+R+PpqWTM6hzZNpNR2GPyWQW0xSQWx5e1iGM0vaMTpmT0ydpjvkyZJMN JYAkUpVHQ7H7e66aYg62Ia/UiyZ1jjo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1725956732; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vcOxYk2DbdWCOhuu8P7USBEBMDbRMgApBCvTiBhhjlE=; b=fg2MBvVCD6TlZoA1X0Ws9dhzipIvtHksmbbukwbvKtqNd4lOG+8j610FrxSBp1mhHbhZ+P GnijqSrJCDAfbeDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id CFDB6132CB; Tue, 10 Sep 2024 08:25:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Qn+YMXsC4GbhOAAAD6G6ig (envelope-from ); Tue, 10 Sep 2024 08:25:31 +0000 Date: Tue, 10 Sep 2024 10:26:20 +0200 Message-ID: <87o74v7w43.wl-tiwai@suse.de> From: Takashi Iwai To: Joshua Pius Cc: Joshua Pius , alsa-devel@alsa-project.org, Jaroslav Kysela , Takashi Iwai , "Steven 'Steve' Kendall" , Karol Kosik , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: usb-audio: Add logitech Audio profile quirk In-Reply-To: References: <20240906211445.3924724-1-joshuapius@google.com> <878qw2d1ry.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 2C42121A44 X-Spam-Score: -3.51 X-Rspamd-Action: no action X-Spamd-Result: default: False [-3.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVRCPT(0.00)[outlook.com]; FREEMAIL_CC(0.00)[chromium.org,alsa-project.org,perex.cz,suse.com,outlook.com,vger.kernel.org]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DWL_DNSWL_BLOCKED(0.00)[suse.de:dkim]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_SEVEN(0.00)[9]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,chromium.org:url,suse.de:dkim,suse.de:mid,suse.de:email] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Flag: NO X-Spam-Level: On Mon, 09 Sep 2024 04:03:36 +0200, Joshua Pius wrote: > > Yes, this change is for UCM profiles. > > Yes this should be a one time occurrence as afterwards effort is being > made to migrate over to UCM v2. OK, then I'll take it. But, I noticed that your Signed-off-by tag was with google.com address while you submitted from chromium.org. Could you align those? thanks, Takashi > > Thanks, > > Joshua P > > > > > > On Sun, Sep 8, 2024 at 3:47 AM Takashi Iwai wrote: > > > > On Fri, 06 Sep 2024 23:14:38 +0200, > > Joshua Pius wrote: > > > > > > Specify shortnames for the following Logitech Devices: Rally bar, Rally > > > bar mini, Tap, MeetUp and Huddle. > > > > > > Signed-off-by: Joshua Pius > > > > Is this change needed only for UCM profiles? UCM v2 should be able to > > handle better to identify models, and such short name updates aren't > > needed for them. > > > > OTOH, I don't mind much to take this kind of small harmless changes > > (unless it happens too frequently). So I'll likely take this, but > > just for verifying the situation. > > > > > > thanks, > > > > Takashi > > > > > > > --- > > > sound/usb/card.c | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > diff --git a/sound/usb/card.c b/sound/usb/card.c > > > index 778de9244f1e..9c411b82a218 100644 > > > --- a/sound/usb/card.c > > > +++ b/sound/usb/card.c > > > @@ -384,6 +384,12 @@ static const struct usb_audio_device_name usb_audio_names[] = { > > > /* Creative/Toshiba Multimedia Center SB-0500 */ > > > DEVICE_NAME(0x041e, 0x3048, "Toshiba", "SB-0500"), > > > > > > + /* Logitech Audio Devices */ > > > + DEVICE_NAME(0x046d, 0x0867, "Logitech, Inc.", "Logi-MeetUp"), > > > + DEVICE_NAME(0x046d, 0x0874, "Logitech, Inc.", "Logi-Tap-Audio"), > > > + DEVICE_NAME(0x046d, 0x087c, "Logitech, Inc.", "Logi-Huddle"), > > > + DEVICE_NAME(0x046d, 0x0898, "Logitech, Inc.", "Logi-RB-Audio"), > > > + DEVICE_NAME(0x046d, 0x08d2, "Logitech, Inc.", "Logi-RBM-Audio"), > > > DEVICE_NAME(0x046d, 0x0990, "Logitech, Inc.", "QuickCam Pro 9000"), > > > > > > DEVICE_NAME(0x05e1, 0x0408, "Syntek", "STK1160"), > > > -- > > > 2.46.0.598.g6f2099f65c-goog > > >